Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix licensing #11782

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Fix licensing #11782

wants to merge 6 commits into from

Conversation

Maniues
Copy link

@Maniues Maniues commented Sep 26, 2024

Split licenses to directory-based licensing to precise what files are under GPL or MIT.

Split licenses to directory-based licensing to precise what files are under GPL or MIT.
@Maniues
Copy link
Author

Maniues commented Sep 26, 2024

@ncannasse @Simn

@Simn
Copy link
Member

Simn commented Sep 26, 2024

I don't know if we want to assert that all other files are part of the Haxe compiler. I don't think you typically declare a tests directory as part of a compiler, and the libs directory is another situation entirely.

But I'm fine with clarifying that the Haxe standard library refers to std in particular.

@Maniues
Copy link
Author

Maniues commented Sep 26, 2024

I don't know if we want to assert that all other files are part of the Haxe compiler. I don't think you typically declare a tests directory as part of a compiler, and the libs directory is another situation entirely.

But I'm fine with clarifying that the Haxe standard library refers to std in particular.

It's hard for me to tell later if the files included in the tests are GPL or not. Same for all files in the top directory

@Maniues
Copy link
Author

Maniues commented Sep 26, 2024

And there can be exception for particular directories like libs

@Maniues
Copy link
Author

Maniues commented Sep 26, 2024

@Simn like these files:

  • extra/
  • src-prebuild/
  • src/ files without header
  • plugins/example (there should be MIT)
  • tests/
  • config files in .github, .devcontainer, .vscode?
  • files in top-level directory:
    top-level files

@Maniues
Copy link
Author

Maniues commented Sep 26, 2024

@Simn what do you think about that?

@Simn
Copy link
Member

Simn commented Sep 26, 2024

To be honest I don't understand what you're saying. You mention that there can be exceptions, but the change in this PR doesn't seem to make exceptions and says "all other files".

@Maniues
Copy link
Author

Maniues commented Sep 26, 2024

I haven't done this yet, I will add it in a few minutes.

I just want to make sure it is okay.

@Maniues
Copy link
Author

Maniues commented Sep 26, 2024

@Simn What about now?

@Simn
Copy link
Member

Simn commented Sep 26, 2024

I like that "If a file does not have a license header" clause, that seems uncomplicated enough.

So I think this is good now, but let me leave this PR open for a few days in case someone who knows about all this stuff happens to pass by!

@Maniues
Copy link
Author

Maniues commented Sep 26, 2024

Okay, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants