fail nicer if unify_min can't find a common type

closes #11684
HaxeFoundation · Jun 4, 2024 · cc105eb · cc105eb
1 parent 245a480
commit cc105eb
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/src/core/tUnification.ml b/src/core/tUnification.ml
@@ -1271,7 +1271,7 @@ module UnifyMinT = struct
 				begin match common_types with
 				| [] ->
 					begin match !first_error with
-					| None -> die "" __LOC__
+					| None -> UnifyMinError([Unify_custom "Could not determine common type, please add a type-hint"],0)
 					| Some(l,p) -> UnifyMinError(l,p)
 					end
 				| hd :: _ ->

diff --git a/tests/misc/projects/Issue11684/Main.hx b/tests/misc/projects/Issue11684/Main.hx
@@ -0,0 +1,5 @@
+function test(input) {
+    return (input is Array) ? input[0] : input;
+}
+
+function main() {}
diff --git a/tests/misc/projects/Issue11684/compile-fail.hxml b/tests/misc/projects/Issue11684/compile-fail.hxml
@@ -0,0 +1,2 @@
+--main Main
+--interp
diff --git a/tests/misc/projects/Issue11684/compile-fail.hxml.stderr b/tests/misc/projects/Issue11684/compile-fail.hxml.stderr
@@ -0,0 +1 @@
+Main.hx:2: characters 42-47 : Could not determine common type, please add a type-hint