Resize the debug watch window whenever something gets added / removed

[ninjamuffin99]

The debugger Watch window would overflow the contents and show offscreen until the user clicks+drags the window around (which then automatically resizes it properly)

This PR makes it so that whenever something is added to the watch window, it will resize itself.

Using FNF (apologies for the .mov files!)
Before

Screen.Recording.2024-09-16.at.6.29.53.PM.mov

After

Screen.Recording.2024-09-16.at.6.32.52.PM.mov

[Geokureli]

I was ready to merge this but, ngl, these seg faults on unit tests are worrying me, dev branch doesn't have this issue, so it's possibly a related to the change

Edit: confirmed, happens on hl tests locally, too:

Class: flixel.system.frontEnds.CameraFrontEndTest .Uncaught exception: Null access
Called from flixel.system.debug.watch.Watch.updateSize(flixel/system/debug/watch/Watch.hx:129)
Called from flixel.system.debug.watch.Watch.removeAll(flixel/system/debug/watch/Watch.hx:117)
Called from flixel.util._FlxSignal.FlxSignal0.dispatch0(flixel/util/FlxSignal.hx:297)
Called from flixel.FlxGame.switchState(flixel/FlxGame.hx:617)
Called from flixel.FlxGame.update(flixel/FlxGame.hx:727)
Called from flixel.FlxGame.step(flixel/FlxGame.hx:680)
Called from FlxTest.step(FlxTest.hx:39)
Called from FlxTest.resetGame(FlxTest.hx:49)
Called from FlxTest.after(FlxTest.hx:31)
Called from $Reflect.callMethod(/usr/local/lib/haxe/std/hl/_std/Reflect.hx:83)
Called from massive.munit.TestRunner.executeTestCases(massive/munit/TestRunner.hx:278)
Called from massive.munit.TestRunner.execute(massive/munit/TestRunner.hx:227)
Called from massive.munit.TestRunner.~run.1(massive/munit/TestRunner.hx:200)
Called from sys.thread._Thread.$HaxeThread.~create.0(/usr/local/lib/haxe/std/hl/_std/sys/thread/Thread.hx:152)

[Geokureli]

gonna merge later today, lmk if you have issues which my changes, otherwise we can fix in post

[ninjamuffin99]

here was the demo WITHOUT reposition(), as I add more things to the watch window, it doesn't move up until I begin dragging the window with my mouse

noreposition.mp4

this one is WITH reposition(), as I add things to it, it will move itself up when it would otherwise potentially become offscreen.

withreposition.mp4

[Geokureli]

maybe it's becuase i tested on html5, but i saw no difference. will try again, what target is that?

[Geokureli]

Yup, my mistake, added back

[Geokureli]

Thanks!

[ninjamuffin99]

woohoo :)

…

On Tue, Sep 24, 2024 at 2:20 PM George Kurelic ***@***.***> wrote: Thanks! — Reply to this email directly, view it on GitHub <#3251 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJTCU3HGJCB6J6Z5FWAMULZYGUPJAVCNFSM6AAAAABOKHKTWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRHE4TIOJUGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>