fix console completion selection on HTML5 #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geokureli
reviewed
Aug 13, 2024
| @@ -37,8 +36,6 @@ class CompletionList extends Sprite | |||
| createPopupEntries(capacity); | |||
| createScrollBar(); | |||
| updateSelectedItem(); | |||
|
|
|||
| FlxG.stage.addEventListener(KeyboardEvent.KEY_DOWN, onKeyDown); | |||
There was a problem hiding this comment.
Do you know why this wasn't working? Is this a preventDefault issue? or is the console blocking these events somehow?
There was a problem hiding this comment.
I'm unsure, I believe it's not console or FlxG.stage specific, since Lib.current.addEventListener also doesn't register tab key, and also the autofocus event listener doesn't work either ("Press TAB to focus the console!") in HTML5. It could be a preventDefault thing!
Geokureli
reviewed
Aug 13, 2024
ninjamuffin99
force-pushed
the
commands-fix
branch
from
307b431
to
8efe1c4
Compare
revert formatting
ninjamuffin99
force-pushed
the
commands-fix
branch
from
8efe1c4
to
e3e01fe
Compare
Geokureli
reviewed
Aug 14, 2024
|
Thanks, if we figure out what's blocking events we can revisit this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On HTML5,
FlxG.stage.addEventListenerseems to not properly do the keyboard events for the CompletionList.This PR changes it so that
onKeyDownis passed through from the debug consoles input event listeners, so using the arrow keys to move through the completions now works on HTML5 properly