George 6.0.0 #3079
George 6.0.0 #3079
Conversation
flixel/FlxCamera.hx
Outdated
| @@ -609,6 +609,8 @@ class FlxCamera extends FlxBasic | |||
| itemToReturn = new FlxDrawItem(); | |||
| } | |||
|
|
|||
| if (graphic.isDestroyed) throw 'Attempted to queue an invalid FlxDrawItem, did you destroy a cached sprite?'; | |||
|
|
|||
There was a problem hiding this comment.
is this triggering for you? My hope with #2974 was to prevent these issues
There was a problem hiding this comment.
in discord:
FlxCamera Line 612 does trigger for me when I try to draw a sprite whose graphic has been disposed
flixel/graphics/FlxGraphic.hx
Outdated
| @@ -511,6 +512,8 @@ class FlxGraphic implements IFlxDestroyable | |||
| */ | |||
| public inline function getFramesCollections(type:FlxFrameCollectionType):Array<Dynamic> | |||
| { | |||
| if (isDestroyed) return []; | |||
There was a problem hiding this comment.
same question, should this have been added in #2974
| @@ -116,6 +116,9 @@ class FlxDrawQuadsItem extends FlxDrawBaseItem<FlxDrawQuadsItem> | |||
| return; | |||
|
|
|||
| var shader = shader != null ? shader : graphics.shader; | |||
|
|
|||
| if (shader == null) throw 'Attempted to render an invalid FlxDrawItem, did you destroy a cached sprite?'; | |||
|
|
|||
| @@ -294,7 +294,7 @@ class BitmapFrontEnd | |||
| if (graphic != null) | |||
| { | |||
| removeKey(graphic.key); | |||
| graphic.destroy(); | |||
| if (!graphic.isDestroyed) graphic.destroy(); | |||
flixel/text/FlxText.hx
Outdated
| @@ -890,7 +890,7 @@ class FlxText extends FlxSprite | |||
| if (oldWidth != newWidth || oldHeight != newHeight) | |||
| { | |||
| // Need to generate a new buffer to store the text graphic | |||
| var key:String = FlxG.bitmap.getUniqueKey("text"); | |||
| var key:String = FlxG.bitmap.getUniqueKey('text(${this.text})'); | |||
There was a problem hiding this comment.
can you talk about the issue this change solved, also, just made this #3081
| @@ -62,7 +62,7 @@ class FlxGraphicsShader extends GraphicsShader | |||
| } | |||
| return vec4(0.0, 0.0, 0.0, 0.0); | |||
| } | |||
| ") | |||
| ", true) | |||
There was a problem hiding this comment.
what does this change?
flixel/graphics/FlxGraphic.hx
Outdated
| @@ -499,7 +499,8 @@ class FlxGraphic implements IFlxDestroyable | |||
| if (collection.type != null) | |||
| { | |||
| var collections:Array<Dynamic> = getFramesCollections(collection.type); | |||
| collections.push(collection); | |||
| if (collections.indexOf(collection) == -1) | |||
There was a problem hiding this comment.
Should I add this to flixel? what does it improve?
There was a problem hiding this comment.
I want to say I made this change back when I was working on trying to resolve an issue with FlxAnimate. I'd definitely keep it as you don't want the list of collections to have duplicate references in it (as that can cause the reference counts to get messed up).
flixel/effects/FlxFlicker.hx
Outdated
| public function pause():Void { | ||
| if (timer == null) return; | ||
| timer.active = false; | ||
| } | ||
|
|
||
| public function resume():Void { | ||
| if (timer == null) return; | ||
| timer.active = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
pretty simple change, why not, same for preventing double release, below
Made an Issue: #3082
Simply comparing the two branches for discussion with @EliteMasterEric. I have no intentions of merging this