Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change resizable="true" for html5 demos #336

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

ninjamuffin99
Copy link
Member

accommodates for #322

we have two options for setting proper fullscreen

  1. changing the iframe / width stuff on the fly
    • this may have ramifications due to CORS policy stuff, where if we wanted to adjust the width/height of game from OUTSIDE of the iframe it might be funky!
  2. allowing the window to be resized to fill the viewport

this PR does option 2, so now when making the iframe fullscreen (whether that's via in-game code, or from the site) it simply fills whatever window it's in.

@ninjamuffin99 ninjamuffin99 merged commit 0370009 into HaxeFlixel:dev Mar 31, 2024
11 of 15 checks passed
@Geokureli Geokureli added this to the 3.2.0 milestone May 1, 2024
@Geokureli Geokureli self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants