Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlxInvaders sounds and music #335

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

ninjamuffin99
Copy link
Member

adds sound effects and music to FlxInvaders

the music is an old track I made, so license / rights is all clear lol!

the sounds are .wav as I've seen other demos use that, and the music is .ogg which works on everything except flash and iOS Safari (i believe). If we make browser mobile versions of all the demos we should make sure we dont forget to check in on that

@ninjamuffin99 ninjamuffin99 merged commit 83e46de into HaxeFlixel:dev Apr 1, 2024
8 of 15 checks passed
@Geokureli
Copy link
Member

I mention here, I want to completely redo this demo at some point because it's such a not fun rendition

that has nothing to do with this PR i just wanted to vent

@Geokureli
Copy link
Member

@ninjamuffin99 Looks like this broke CI on flash targets

source/PlayerShip.hx:68: characters 15-20 : flixel.sound.FlxSound has no field pitch
source/PlayState.hx:216: characters 13-18 : flixel.sound.FlxSound has no field pitch

@ninjamuffin99
Copy link
Member Author

hmmm... instead of wrapping the demo in FLX_PITCH, do you think on the flixel side we can just document that setting pitch won't do anything on flash targets? I think people using flixel for flash purposes are likely low nowadays!

Along with that, did we want to still even build / compile flash demos?

Otherwise, I can wrap it in FLX_PITCH 🤝

@Geokureli
Copy link
Member

Im not against the convenience of adding a do-nothing pitch to flash, but i still think the demo should still check FLX_PITCH, since it's the easier fix and it can teach people about how to use the FLX_PITCH flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants