Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle service account casing in google_bigquery_dataset_access #11875

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wj-chen
Copy link
Member

@wj-chen wj-chen commented Sep 30, 2024

Fixes hashicorp/terraform-provider-google#19547.

A follow-up to #11477. Service account names come back from the GET API in their original capitalization instead of being normalized to lower-case so need to be specifically handled.

There isn't a good way to add a unit test organically since google_service_account only allows lower-case names and the error came from customers creating upper-case service accounts outside of Terraform.

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed an error which could occur with service account field values containing non-lower-case characters in `google_bigquery_dataset_access`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 120
Passed tests: 110
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • bigquery

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_bigquery_dataset_access unable to handle service account emails with mixed/upper cases
3 participants