Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min cpu platform error message 11289 backup #11872

Draft
wants to merge 3 commits into
base: legacy-ruby
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2461,37 +2461,44 @@ func resourceComputeInstanceUpdate(d *schema.ResourceData, meta interface{}) err
}
}

if d.HasChange("min_cpu_platform") {
minCpuPlatform := d.Get("min_cpu_platform")
req := &compute.InstancesSetMinCpuPlatformRequest{
MinCpuPlatform: minCpuPlatform.(string),
}
op, err := config.NewComputeClient(userAgent).Instances.SetMinCpuPlatform(project, zone, instance.Name, req).Do()
if err != nil {
return err
}
opErr := ComputeOperationWaitTime(config, op, project, "updating min cpu platform", userAgent, d.Timeout(schema.TimeoutUpdate))
if opErr != nil {
return opErr
}
}
if d.HasChange("min_cpu_platform") || d.HasChange("machine_type") {
err = transport_tpg.Retry(transport_tpg.RetryOptions{
RetryFunc: func() error {
instance, err := config.NewComputeClient(userAgent).Instances.Get(project, zone, instance.Name).Do() //fetch instance for fingerprints
if err != nil {
return fmt.Errorf("Error retrieving instance: %s", err)
}
instanceFromConfig, err := expandComputeInstance(project, d, config) //need raw disk encryption keys from config for the Instaces.Update() call
if err != nil {
return fmt.Errorf("Error retrieving instance config: %s", err)
}
for _, disk := range instanceFromConfig.Disks {
disk.InitializeParams = nil //cannot have both `initialize_params` and source `specified`
}
mcp := d.Get("min_cpu_platform")
mt, err := tpgresource.ParseMachineTypesFieldValue(d.Get("machine_type").(string), d, config)
if err != nil {
return fmt.Errorf("Error retrieving instance's machine_type: %s", err)
}

if d.HasChange("machine_type") {
mt, err := tpgresource.ParseMachineTypesFieldValue(d.Get("machine_type").(string), d, config)
if err != nil {
return err
}
req := &compute.InstancesSetMachineTypeRequest{
MachineType: mt.RelativeLink(),
}
op, err := config.NewComputeClient(userAgent).Instances.SetMachineType(project, zone, instance.Name, req).Do()
instance.Disks = instanceFromConfig.Disks
instance.MinCpuPlatform = mcp.(string)
instance.MachineType = mt.RelativeLink()

op, err := config.NewComputeClient(userAgent).Instances.Update(project, zone, instance.Name, instance).Do()
if err != nil {
return fmt.Errorf("Error updating instance: %s", err)
}
opErr := ComputeOperationWaitTime(config, op, project, "updating instance", userAgent, d.Timeout(schema.TimeoutUpdate))
if opErr != nil {
return opErr
}
return nil
},
})
if err != nil {
return err
}
opErr := ComputeOperationWaitTime(config, op, project, "updating machinetype", userAgent, d.Timeout(schema.TimeoutUpdate))
if opErr != nil {
return opErr
}
}

if d.HasChange("service_account.0.email") || scopesChange {
Expand Down
Loading