Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable update in apigee reference #11865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

george-peng
Copy link
Contributor

Add update capability to allow the reference to be updated without needing to recreate the entire resource.

Update API : https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.environments.references/update

Release Note Template for Downstream PRs (will be copied)

apigee: enable update in `google_apigee_env_references`

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 28, 2024
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/apigee and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 30, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 14
Skipped tests: 29
Affected tests: 1

Click here to see the affected service packages
  • apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/apigee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants