-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceptance tests for request_timeout
#11848
base: main
Are you sure you want to change the base?
Add acceptance tests for request_timeout
#11848
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…d `google_provider_config_plugin_framework` data source
…t difference vs SDK
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4103 Click here to see the affected service packages
View the build log |
} | ||
} | ||
|
||
func testAccSdkProvider_request_timeout_providerDefault(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to put this comment in, explaining the different defaults for this field in the SDK vs PF code. I'll save adding it until after review, as it's something worth making explicit to the reviewer.
func testAccSdkProvider_request_timeout_providerDefault(t *testing.T) { | |
// In the SDK version of the provider config code request_timeout has a zero value of "0s" and no default. | |
// The final 'effective' value is "120s", matching the default used in the plugin-framework version of the provider config code. | |
// See : https://github.com/hashicorp/terraform-provider-google/blob/09cb850ee64bcd78e4457df70905530c1ed75f19/google/transport/config.go#L1228-L1233 | |
func testAccSdkProvider_request_timeout_providerDefault(t *testing.T) { |
@BBBmau requesting you as reviewer as you have experience about the different defaults for SDK vs PF from the past |
request_timeout
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
This PR adds acceptance tests for usage of request_timeout that demonstrate:
use cases: how does this argument impact the providers behaviour in plan/apply
Release Note Template for Downstream PRs (will be copied)