Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FOR_MIGRATION InternalRange objects #11830

Closed
wants to merge 0 commits into from

Conversation

sebkalis
Copy link

Support for for-migration InternalRange resources.

A new value of usage enum is introduced: FOR_MIGRATION. Such ranges must also contain a nested object consisting of 2 strings: source - an URI/path to the migration source (a subnet resource being migrated, in its original location) and a target - an URI/path for the planned future resource (a subnet) to be recreated in the new location.

Fixes hashicorp/terraform-provider-google#19636

Release Note Template for Downstream PRs (will be copied)

networkconnectivity: Added support for FOR_MIGRATION InternalRange resources.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@c2thorn
Copy link
Member

c2thorn commented Sep 26, 2024

Hi @sebkalis,
We recently migrated the repository. You'll need to rebase or start a new PR from the latest changes in the main branch.

You basically just need to copy-paste the changes you made in mmv1/products/networkconnectivity/go_InternalRange.yaml
to the latest mmv1/products/networkconnectivity/InternalRange.yaml

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 79 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 79 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 97
Passed tests: 83
Skipped tests: 14
Affected tests: 0

Click here to see the affected service packages
  • sql

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@sebkalis sebkalis deleted the ir_migration branch September 27, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for usage=FOR_MIGRATION InternalRange resources to networkconnectivity product
3 participants