Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize GitHub config project directory on save to make it relative #547

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

jpreynat
Copy link
Member

Because using an absolute path value (ie starting by / like /path/to/project) doesn't work, we make sure that paths are always relative.

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: 09e5b1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@gitbook/integration-github Minor
@gitbook/integration-gitlab Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@taranvohra taranvohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! can you also add changesets (for github & gitlab) so when we merge we can have a release PR to trigger a new deployment for these integrations

integrations/github/src/installation.ts Show resolved Hide resolved
@jpreynat jpreynat merged commit c3e0c55 into main Sep 19, 2024
2 checks passed
@jpreynat jpreynat deleted the normalize-github-project-directory branch September 19, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants