Feature/16/backend flow game start #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add StartGameJob to trigger start games regularly 2. set game status to STARTED, direction to RIGHT, mode to LIGHT 3. assign initial player 4. random deal 5. send sse broadcast event 6. send personal events 7. presenter for personal events and broadcast event 8. add event type for join broadcast event, started broadcast event, started personal event 9. refactor: 改 exception 10. refactor: use Optional to handle emitter not found for SseService send broadcast event Closes #16
將發送 sse event 跟產 response 的工作搬到 use case 層，這樣 controller 就不用管 presenter。
問題: 沒加 synchronized 前，在同一時間有多個 join request 進來時，有可能會同時拿不到可加入的遊戲。 結果: 1. 建立了多個新的遊戲，玩家會分散掉。 2. 沒有先將玩家湊滿才開新遊戲 解法: 方法加上 synchronized，確保同一時間只有一個請求可以 join game 延伸問題: 此解法在多台 api 時會失效，屆時需再想其他解法。 Closes #16
1. 移除 job，直接在 GameJoinUseCase 中判斷 game.isFull()，並讓 GameStartPresenter 產生遊戲開始相關的 event，由 sseService 送出。 2. 修正 join 的 e2e 測試，因為有調整廣播 event 內容，加上 eventType，但測試忘記調整。 Closes #16
Closes #16
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
完成 #16