feat: make it faster with early returns ⚡️

GSTJ · May 12, 2023 · d86a810 · d86a810
1 parent 8e39ffd
commit d86a810
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 19 deletions.
diff --git a/package.json b/package.json
@@ -14,7 +14,7 @@
     "linting",
     "code quality"
   ],
-  "version": "1.0.2",
+  "version": "1.0.3",
   "main": "lib/index.js",
   "scripts": {
     "prepack": "npmignore --auto --commentLines=autogenerated && npm run build",

diff --git a/src/rules/jsx-explicit-boolean.js b/src/rules/jsx-explicit-boolean.js
@@ -12,37 +12,35 @@ module.exports = {
     return {
       LogicalExpression(node) {
         // We're only interested in && operators
-        if (node.operator !== '&&') {
-          return;
-        }
+        if (node.operator !== '&&') return;
 
         // We're only interested in JSX elements on the right-hand side
-        if (node.right.type !== 'JSXElement') {
-          return;
-        }
+        if (node.right.type !== 'JSXElement') return;
 
         const { left } = node;
+
         const isExplicitBooleanConversion = left.type === 'CallExpression'
           && left.callee.type === 'Identifier'
           && left.callee.name === 'Boolean';
+        if (isExplicitBooleanConversion) return;
 
         const isBooleanLiteral = left.type === 'Literal' && typeof left.value === 'boolean';
+        if (isBooleanLiteral) return;
 
         const isBooleanVariable = left.type === 'Identifier'
           && context.getScope().variables.some((variable) => variable.name === left.name && variable.defs.some((def) => def.type === 'Variable' && typeof def.node.init.value === 'boolean'));
+        if (isBooleanVariable) return;
 
-        if (!isExplicitBooleanConversion && !isBooleanLiteral && !isBooleanVariable) {
-          context.report({
-            node,
-            messageId: 'booleanConversion',
-            fix(fixer) {
-              return fixer.replaceTextRange(
-                [left.range[0], left.range[1]],
-                `Boolean(${context.getSourceCode().getText(left)})`,
-              );
-            },
-          });
-        }
+        context.report({
+          node,
+          messageId: 'booleanConversion',
+          fix(fixer) {
+            return fixer.replaceTextRange(
+              [left.range[0], left.range[1]],
+              `Boolean(${context.getSourceCode().getText(left)})`,
+            );
+          },
+        });
       },
     };
   },