Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache latest fuels version #3186

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

feat: cache latest fuels version #3186

wants to merge 20 commits into from

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Sep 19, 2024 •
edited
Loading

Closes TS-654

Summary

This PR adds a basic local cache for the latest fuels version fetched by the fuels CLI.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 self-assigned this Sep 19, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 1:49pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 1:49pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 27, 2024 1:49pm

@github-actions github-actions bot added the feat Issue is a feature label Sep 19, 2024
@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review September 19, 2024 10:12
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3186 will improve performances by ×2.8

Comparing dp/fuels-version-cache (43dbb55) with master (e7c2c30)

Summary

⚡ 1 improvements
✅ 20 untouched benchmarks

Benchmarks breakdown

Benchmark master dp/fuels-version-cache Change
⚡ Instantiate a new Unlocked wallet 106 ms 38.3 ms ×2.8

@Dhaiwat10 @petertonysmith94
remove extra check
591c32a 
Co-authored-by: Peter Smith <[email protected]>
nedsalk
nedsalk previously approved these changes Sep 19, 2024
View reviewed changes
Torres-ssf
Torres-ssf previously approved these changes Sep 24, 2024
View reviewed changes
petertonysmith94
petertonysmith94 reviewed Sep 25, 2024
View reviewed changes
packages/fuels/src/cli/utils/getLatestFuelsVersion.test.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is with these errors?

Screenshot 2024-09-25 at 06 54 01

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, they pass locally. Investigating

packages/fuels/src/cli/utils/checkForAndDisplayUpdates.test.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this tests needs to be re-synced

image

@Dhaiwat10 Dhaiwat10 marked this pull request as draft September 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 left review comments

@Torres-ssf Torres-ssf Torres-ssf left review comments

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement caching to check latest fuels version
6 participants
@Dhaiwat10 @arboleya @petertonysmith94 @nedsalk @Torres-ssf @danielbate