Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: storage slots auto-load from typegen #3134

Merged
merged 5 commits into from
Sep 9, 2024
Merged

fix: storage slots auto-load from typegen #3134

merged 5 commits into from
Sep 9, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Sep 9, 2024 •
edited by arboleya
Loading

Release notes

In this release, we:

  • Fixed issue with storage slots not being auto-loaded when deploying a contract

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Sep 9, 2024
@petertonysmith94 petertonysmith94 self-assigned this Sep 9, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 10:36am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 10:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 9, 2024 10:36am

@petertonysmith94 petertonysmith94 marked this pull request as ready for review September 9, 2024 08:08
danielbate
danielbate approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@petertonysmith94 petertonysmith94 enabled auto-merge (squash) September 9, 2024 10:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Coverage Report:

Lines Branches Functions Statements
79.37%(+0%) 72.15%(+0%) 77.73%(+0%) 79.44%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit ccfa699 into master Sep 9, 2024
23 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/autogenerate-storage-slots branch September 9, 2024 10:51
@fuel-service-user fuel-service-user mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@nedsalk nedsalk nedsalk approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StorageSlots not auto-loaded by Typegen
4 participants
@petertonysmith94 @danielbate @nedsalk @Dhaiwat10