Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub.hx #376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update GitHub.hx #376

wants to merge 2 commits into from
+51 −1

Conversation

NebulaStellaNova
Copy link
Contributor

Add getCommits (Will be used on the main menu)

@NebulaStellaNova
Update GitHub.hx
daa85ca 
Add getCommits (Will be used on the main menu)
@NeeEoo
Copy link
Member

NeeEoo commented Sep 1, 2024

this only returns the last 30 commits btw

@NebulaStellaNova
Copy link
Contributor Author

that's fine, it just needs to be used for the most recent commit id

@NeeEoo
Copy link
Member

NeeEoo commented Sep 1, 2024

https://api.github.com/repos/FNF-CNE-Devs/CodenameEngine/commits

looking at this it doesnt say the amount

@NexIsDumb
Copy link
Member

and btw i dont think that GitHubRelease is the right structure for commits, you should create a new one

NebulaStellaNova
NebulaStellaNova commented Sep 1, 2024
View reviewed changes
Copy link
Contributor Author

@NebulaStellaNova NebulaStellaNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added get commit count

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NebulaStellaNova @NeeEoo @NexIsDumb