-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File and folder organization #279
base: main
Are you sure you want to change the base?
Conversation
keep generateDocs.bat since we use a seperate repo where we store the docs since its cleaner that way |
and im not a fan of the movement of the shell scripts cne and update since ppl might get confused |
I would also avoid putting stuff in a docs folder because thats what the docsUpdate.bat needs whenever we have to update the pages repository |
Will return it, give me a minute |
Should I return them to the root folder or do you have any other ideas? |
Fair enough, I could rename the folder to something else |
I'll wait until you guys decide where the shell scripts need to be, I personally dislike them being in the root folder, cause it's just kinda cluttered, but if you wish to keep it that way, then I'll put em there 👍 |
sure, we'll for sure tell you |
Alright, don't mind waiting, take your time |
Please make the 2 files have the correct pemissions |
i also think this commit will have to be merged after the update is released |
…NF-CNE-Devs#292) * Update AssetsLibraryList.hx * Update AssetsLibraryList.hx
Which ones? |
The 2 shell files |
@doggogit remove th commit that i reverted from the guy with the lib changes |
How do you remove commits like that... I have no clue |
hold on |
…eplay) (FNF-CNE-Devs#292)" This reverts commit b790fb7.
there ya go |
Ah, alright, I don't use GitHub Desktop, but good to know 👍 |
Is this alright? |
Hi, first PR here, wanted to do a clean-up, both folder and file wise.
Changes
BETAMESSAGE.md
as I feel it should be highlighted within the patch notes themselves and the extra file isn't necessary. If people read the patch notes and fuck around with the engine itself, this file isn't needed.README
has been shortened down, splitting sections into their own files/extensions inother/
.What can you do or not do
intoFEATURES.md
.How to build
has been moved into a completely new file namedBUILDING.md
.SECRET REPO INSTRUCTIONS.md
has been moved intoother/
fromart/
.flashFiles
.teasers/
.preloaderArt
,Funkin.bmp
,c_z.mp3
, etc. since they go unused.art/
folder.libs.xml
file from the root folder tocommandline/
.If you wish for any files to be returned or if you feel like adjustments can be made, just make a comment or leave a review. I'll be sure to take a look. Cheers.