Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File and folder organization #279

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

doggogit
Copy link

@doggogit doggogit commented Apr 13, 2024

Hi, first PR here, wanted to do a clean-up, both folder and file wise.

Changes

  • Removed BETAMESSAGE.md as I feel it should be highlighted within the patch notes themselves and the extra file isn't necessary. If people read the patch notes and fuck around with the engine itself, this file isn't needed.
  • The README has been shortened down, splitting sections into their own files/extensions in other/.
    • Moved What can you do or not do into FEATURES.md.
    • How to build has been moved into a completely new file named BUILDING.md.
    • SECRET REPO INSTRUCTIONS.md has been moved into other/ from art/.
  • Removal of unedited/unwanted .fla files, kept the edited ones in flashFiles.
  • Put all the teaser layers and image files into one folder called teasers/.
  • Removed some base game files like preloaderArt, Funkin.bmp, c_z.mp3, etc. since they go unused.
  • Removed some of the meme-y files put into the art/ folder.
  • Moved the libs.xml file from the root folder to commandline/.

If you wish for any files to be returned or if you feel like adjustments can be made, just make a comment or leave a review. I'll be sure to take a look. Cheers.

@NeeEoo
Copy link
Member

NeeEoo commented Apr 13, 2024

keep generateDocs.bat since we use a seperate repo where we store the docs since its cleaner that way

@NeeEoo
Copy link
Member

NeeEoo commented Apr 13, 2024

and im not a fan of the movement of the shell scripts cne and update since ppl might get confused

@NexIsDumb
Copy link
Member

I would also avoid putting stuff in a docs folder because thats what the docsUpdate.bat needs whenever we have to update the pages repository

@doggogit
Copy link
Author

keep generateDocs.bat since we use a seperate repo where we store the docs since its cleaner that way

Will return it, give me a minute

@doggogit
Copy link
Author

and im not a fan of the movement of the shell scripts cne and update since ppl might get confused

Should I return them to the root folder or do you have any other ideas?

@doggogit
Copy link
Author

I would also avoid putting stuff in a docs folder because thats what the docsUpdate.bat needs whenever we have to update the pages repository

Fair enough, I could rename the folder to something else

@doggogit
Copy link
Author

I'll wait until you guys decide where the shell scripts need to be, I personally dislike them being in the root folder, cause it's just kinda cluttered, but if you wish to keep it that way, then I'll put em there 👍

@NexIsDumb
Copy link
Member

sure, we'll for sure tell you
but you'll have to wait a little as we'll look through all the pull requests for good as soon as we finish the new update

@doggogit
Copy link
Author

sure, we'll for sure tell you but you'll have to wait a little as we'll look through all the pull requests for good as soon as we finish the new update

Alright, don't mind waiting, take your time

@NeeEoo
Copy link
Member

NeeEoo commented May 31, 2024

Please make the 2 files have the correct pemissions

@NeeEoo NeeEoo marked this pull request as draft May 31, 2024 15:24
@NeeEoo
Copy link
Member

NeeEoo commented May 31, 2024

i also think this commit will have to be merged after the update is released

@doggogit
Copy link
Author

Please make the 2 files have the correct pemissions

Which ones?

@NeeEoo
Copy link
Member

NeeEoo commented May 31, 2024

The 2 shell files

@NexIsDumb
Copy link
Member

@doggogit remove th commit that i reverted from the guy with the lib changes

@doggogit
Copy link
Author

@doggogit remove th commit that i reverted from the guy with the lib changes

How do you remove commits like that... I have no clue

@NexIsDumb
Copy link
Member

@doggogit remove th commit that i reverted from the guy with the lib changes

How do you remove commits like that... I have no clue

hold on

@NexIsDumb
Copy link
Member

NexIsDumb commented Jun 18, 2024

there ya go
for reverting commits you can just right click a commit in github desktop and select revert changes in commit

@doggogit
Copy link
Author

there ya go for reverting commits you can just right click a commit in github desktop and select revert changes in commit

Ah, alright, I don't use GitHub Desktop, but good to know 👍

@NeeEoo
Copy link
Member

NeeEoo commented Aug 3, 2024

Skärmavbild 2024-08-03 kl  18 55 57

Can you move them back?

@doggogit
Copy link
Author

doggogit commented Aug 3, 2024

Skärmavbild 2024-08-03 kl 18 55 57 Can you move them back?

Where to?

@NeeEoo
Copy link
Member

NeeEoo commented Aug 3, 2024

Skärmavbild 2024-08-03 kl 18 55 57

Can you move them back?

Where to?

Back to original place

@doggogit
Copy link
Author

doggogit commented Aug 3, 2024

Is this alright?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants