Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Turns out going
key_path::get(1)
infers1
to be ani32
, sinceget
takes animpl Into<Value>
. So we somehow need to cast from at leasti32
tousize
for accessing lists and arrays with key paths.To remove the lossly conversion I can think of two options:
TryFrom
and panic if the conversion fails. This would only happen when accessing a very large list.key_path::get
is also used for accessing maps (hence why it takesimpl Into<Value>
) but we could make separate functions for list/array and map access. Perhapsget_seq(usize)
andget_map(impl Into<Value>)
.I personally prefer option one because I like how list/array and map access is the same, but it is perhaps a bit disingenuous. I like how it matches rusts'
Index
trait though. What do you think @bnjbvr?Related Issues
Fixes #76