Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relu activation function #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add relu activation function #135

wants to merge 3 commits into from

Conversation

MartinMSPedersen
Copy link

Make it possible to choose the relu activation function

@MartinMSPedersen
Copy link
Author

one error

@DaGuT
Copy link

DaGuT commented Aug 30, 2019 •
edited
Loading

If it is ever going to be merged:
There is an incorrect naming of relu function e1e13fc (you named it tanh)

Also, just as I was once told, this PR is not for relu only, they might not accept it because of that.

DaGuT
DaGuT suggested changes Aug 30, 2019
View reviewed changes
Copy link

@DaGuT DaGuT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a new commit with proposed change to "let relu" instead of "tanh", pls :D

Idk how to do this review, too many steps :/

lib/nn.js
@@ -17,6 +17,11 @@ let tanh = new ActivationFunction(
y => 1 - (y * y)
);

let tanh = new ActivationFunction(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be "let relu" instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaGuT DaGuT DaGuT requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinMSPedersen @DaGuT