Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.google.errorprone:error_prone_core to v2.33.0 #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 30, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.errorprone:error_prone_core (source) 2.32.0 -> 2.33.0 age adoption passing confidence

Release Notes

google/error-prone (com.google.errorprone:error_prone_core)

v2.33.0: Error Prone 2.33.0

Compare Source

Similar to release 2.32.0, the minimum support JDK version to run Error Prone is JDK 17 (#​3803). Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will requires using JDK 17 or newer for compilation and setting --release or -source/-target/-bootclasspath.

Changes:

New checks:

Full changelog: google/error-prone@v2.32.0...v2.33.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

github-actions bot commented Sep 30, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit f366754. ± Comparison against base commit f6aec56.

♻️ This comment has been updated with latest results.

@renovate renovate bot force-pushed the renovate/errorprone.version branch from 0ff8c64 to 8a36fe8 Compare October 1, 2024 13:40
Copy link
Member

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code/QA check no longer passes because

[INFO] -------------------------------------------------------------
Warning:  COMPILATION WARNING : 
[INFO] -------------------------------------------------------------
Warning:  /home/runner/work/planmonitor-wonen-api/planmonitor-wonen-api/src/main/java/nl/b3p/planmonitorwonen/api/model/PlanregistratieComplete.java:[11,20] [ArrayRecordComponent] Record components should not be arrays.
    (see https://errorprone.info/bugpattern/ArrayRecordComponent)
Warning:  /home/runner/work/planmonitor-wonen-api/planmonitor-wonen-api/src/main/java/nl/b3p/planmonitorwonen/api/model/PlanregistratieComplete.java:[12,21] [ArrayRecordComponent] Record components should not be arrays.
    (see https://errorprone.info/bugpattern/ArrayRecordComponent)

the arrays of Plancategorie and Detailplanning should probably be ImmutableLists, see https://errorprone.info/bugpattern/ArrayRecordComponent

@mprins mprins force-pushed the renovate/errorprone.version branch from 0d8cee4 to f366754 Compare October 2, 2024 09:27
Copy link
Contributor Author

renovate bot commented Oct 2, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant