Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of .net generator from tsp converter #5008

Merged
merged 21 commits into from
Sep 6, 2024

Conversation

pshao25
Copy link
Member

@pshao25 pshao25 commented Aug 28, 2024

Fix #4995

What still left is:

  1. Multi path cases depend on TypeSpec design: "arm-apimanagement", "arm-compute", "arm-machinelearningservices"
  2. Expanded cases depend on TypeSpec design: "arm-dns"
  3. Deal with directives: an example is arm-storage.

Copy link
Member

@tadelesh tadelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we still want to keep resources.json, it is kind of a middle output from .net codegen. since we have the resource detection logic, then we could compose the typespec resource model directly.

@pshao25
Copy link
Member Author

pshao25 commented Sep 2, 2024

why we still want to keep resources.json, it is kind of a middle output from .net codegen. since we have the resource detection logic, then we could compose the typespec resource model directly.

We can definitely delete it, and it is actual my next step. In this PR, I don't want to do take this step too big, therefore to keep this file so that we could see the diff clearly.

@pshao25 pshao25 merged commit 2547245 into Azure:main Sep 6, 2024
10 checks passed
@pshao25 pshao25 deleted the rewriteCSharp branch September 6, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace .net dependency from openapi-to-typespec
4 participants