Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#1704 - Store the status changes in a records #1837

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Feature/#1704 - Store the status changes in a records #1837

merged 8 commits into from
Sep 26, 2024

Conversation

trgiangdo
Copy link
Member

Resolves #1704

All status changes of a job is now recorded in a dictionary.

@trgiangdo trgiangdo self-assigned this Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18820 16304 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/_orchestrator/_dispatcher/_development_job_dispatcher.py 81% 🟢
taipy/core/_orchestrator/_dispatcher/_standalone_job_dispatcher.py 100% 🟢
taipy/core/job/_job_converter.py 94% 🟢
taipy/core/job/_job_model.py 96% 🟢
taipy/core/job/job.py 93% 🟢
taipy/core/submission/submission.py 95% 🟢
TOTAL 93% 🟢

updated for commit: 26b3260 by action🐍

toan-quach
toan-quach approved these changes Sep 26, 2024
View reviewed changes
taipy/core/job/job.py Show resolved Hide resolved
toan-quach
toan-quach previously approved these changes Sep 26, 2024
View reviewed changes
@trgiangdo trgiangdo force-pushed the feature/#1704-storing-job-status-change-timestamp branch from e5779fc to 1fc5e71 Compare September 26, 2024 05:59
@trgiangdo trgiangdo force-pushed the feature/#1704-storing-job-status-change-timestamp branch from 1fc5e71 to d174aa3 Compare September 26, 2024 06:07
@trgiangdo trgiangdo mentioned this pull request Sep 26, 2024
Merged
toan-quach
toan-quach previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@toan-quach toan-quach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only reviewed the code and not the test but lgtm

taipy/core/job/job.py Outdated Show resolved Hide resolved
taipy/core/job/job.py Show resolved Hide resolved
jrobinAV
jrobinAV requested changes Sep 26, 2024
View reviewed changes
taipy/core/job/job.py Outdated Show resolved Hide resolved
taipy/core/job/job.py Outdated Show resolved Hide resolved
@trgiangdo trgiangdo merged commit 15359f5 into develop Sep 26, 2024
126 checks passed
@trgiangdo trgiangdo deleted the feature/#1704-storing-job-status-change-timestamp branch September 26, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrobinAV jrobinAV jrobinAV approved these changes

@toan-quach toan-quach toan-quach approved these changes

@joaoandre-avaiga joaoandre-avaiga Awaiting requested review from joaoandre-avaiga

Assignees

@trgiangdo trgiangdo

Labels
Core: Job & Orchestrator ✨New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storing the information about Job's status changes
3 participants
@trgiangdo @jrobinAV @toan-quach