Skip to content

Commit

Permalink
fixed issue of import in enterprise
Browse files Browse the repository at this point in the history
  • Loading branch information
Toan Quach authored and Toan Quach committed Oct 2, 2024
1 parent cf7593b commit 79ff677
Show file tree
Hide file tree
Showing 12 changed files with 56 additions and 45 deletions.
6 changes: 3 additions & 3 deletions taipy/core/_cli/_core_cli_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@

from taipy._cli._base_cli._abstract_cli import _AbstractCLI

from ..common._check_dependencies import _TAIPY_ENTERPRISE_CORE_MODULE, _using_enterprise
from ..common._check_dependencies import EnterpriseChecker
from ._core_cli import _CoreCLI


class _CoreCLIFactory:
@staticmethod
def _build_cli() -> Type[_AbstractCLI]:
if _using_enterprise():
module = import_module(_TAIPY_ENTERPRISE_CORE_MODULE + "._cli._core_cli")
if EnterpriseChecker._using_enterprise():
module = import_module(EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + "._cli._core_cli")
core_cli = attrgetter("_CoreCLI")(module)
else:
core_cli = _CoreCLI
Expand Down
3 changes: 0 additions & 3 deletions taipy/core/_manager/_manager_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@


class _ManagerFactory:
_TAIPY_ENTERPRISE_MODULE = "taipy.enterprise"
_TAIPY_ENTERPRISE_CORE_MODULE = _TAIPY_ENTERPRISE_MODULE + ".core"

@classmethod
@abstractmethod
def _build_manager(cls) -> Type[_Manager]: # type: ignore
Expand Down
6 changes: 3 additions & 3 deletions taipy/core/_version/_cli/_version_cli_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@

from taipy._cli._base_cli._abstract_cli import _AbstractCLI

from ...common._check_dependencies import _TAIPY_ENTERPRISE_CORE_MODULE, _using_enterprise
from ...common._check_dependencies import EnterpriseChecker
from ._version_cli import _VersionCLI


class _VersionCLIFactory:
@staticmethod
def _build_cli() -> Type[_AbstractCLI]:
if _using_enterprise():
module = import_module(_TAIPY_ENTERPRISE_CORE_MODULE + "._version._cli._version_cli")
if EnterpriseChecker._using_enterprise():
module = import_module(EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + "._version._cli._version_cli")
core_cli = attrgetter("_VersionCLI")(module)
else:
core_cli = _VersionCLI
Expand Down
9 changes: 5 additions & 4 deletions taipy/core/_version/_version_manager_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

from .._manager._manager_factory import _ManagerFactory
from ..common import _utils
from ..common._check_dependencies import _TAIPY_ENTERPRISE_CORE_MODULE, _using_enterprise
from ..common._check_dependencies import EnterpriseChecker
from ._version_fs_repository import _VersionFSRepository
from ._version_manager import _VersionManager

Expand All @@ -25,12 +25,13 @@ class _VersionManagerFactory(_ManagerFactory):
@classmethod
@lru_cache
def _build_manager(cls) -> Type[_VersionManager]:
if _using_enterprise():
if EnterpriseChecker._using_enterprise():
version_manager = _utils._load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + "._version._version_manager", "_VersionManager"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + "._version._version_manager", "_VersionManager"
) # type: ignore
build_repository = _utils._load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + "._version._version_manager_factory", "_VersionManagerFactory"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + "._version._version_manager_factory",
"_VersionManagerFactory",
)._build_repository # type: ignore
else:
version_manager = _VersionManager
Expand Down
12 changes: 7 additions & 5 deletions taipy/core/common/_check_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
# specific language governing permissions and limitations under the License.
from importlib import util

_TAIPY_ENTERPRISE_MODULE = "taipy.enterprise"
_TAIPY_ENTERPRISE_CORE_MODULE = _TAIPY_ENTERPRISE_MODULE + ".core"


def _check_dependency_is_installed(module_name: str, package_name: str) -> None:
"""
Expand All @@ -34,5 +31,10 @@ def _check_dependency_is_installed(module_name: str, package_name: str) -> None:
)


def _using_enterprise() -> bool:
return util.find_spec(_TAIPY_ENTERPRISE_MODULE) is not None
class EnterpriseChecker:
_TAIPY_ENTERPRISE_MODULE = "taipy.enterprise"
_TAIPY_ENTERPRISE_CORE_MODULE = _TAIPY_ENTERPRISE_MODULE + ".core"

@classmethod
def _using_enterprise(cls) -> bool:
return util.find_spec(cls._TAIPY_ENTERPRISE_MODULE) is not None
11 changes: 7 additions & 4 deletions taipy/core/cycle/_cycle_manager_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from typing import Type

from .._manager._manager_factory import _ManagerFactory
from ..common._check_dependencies import _using_enterprise
from ..common._check_dependencies import EnterpriseChecker
from ..common._utils import _load_fct
from ..cycle._cycle_manager import _CycleManager
from ._cycle_fs_repository import _CycleFSRepository
Expand All @@ -25,10 +25,13 @@ class _CycleManagerFactory(_ManagerFactory):
@classmethod
@lru_cache
def _build_manager(cls) -> Type[_CycleManager]:
if _using_enterprise():
cycle_manager = _load_fct(cls._TAIPY_ENTERPRISE_CORE_MODULE + ".cycle._cycle_manager", "_CycleManager") # type: ignore
if EnterpriseChecker._using_enterprise():
cycle_manager = _load_fct(
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".cycle._cycle_manager", "_CycleManager"
) # type: ignore
build_repository = _load_fct(
cls._TAIPY_ENTERPRISE_CORE_MODULE + ".cycle._cycle_manager_factory", "_CycleManagerFactory"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".cycle._cycle_manager_factory",
"_CycleManagerFactory",
)._build_repository # type: ignore
else:
cycle_manager = _CycleManager
Expand Down
10 changes: 6 additions & 4 deletions taipy/core/data/_data_manager_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from typing import Type

from .._manager._manager_factory import _ManagerFactory
from ..common._check_dependencies import _TAIPY_ENTERPRISE_CORE_MODULE, _using_enterprise
from ..common._check_dependencies import EnterpriseChecker
from ..common._utils import _load_fct
from ._data_fs_repository import _DataFSRepository
from ._data_manager import _DataManager
Expand All @@ -24,10 +24,12 @@ class _DataManagerFactory(_ManagerFactory):
@classmethod
@lru_cache
def _build_manager(cls) -> Type[_DataManager]:
if _using_enterprise():
data_manager = _load_fct(_TAIPY_ENTERPRISE_CORE_MODULE + ".data._data_manager", "_DataManager") # type: ignore
if EnterpriseChecker._using_enterprise():
data_manager = _load_fct(
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".data._data_manager", "_DataManager"
) # type: ignore
build_repository = _load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + ".data._data_manager_factory", "_DataManagerFactory"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".data._data_manager_factory", "_DataManagerFactory"
)._build_repository # type: ignore
else:
data_manager = _DataManager
Expand Down
10 changes: 6 additions & 4 deletions taipy/core/job/_job_manager_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from typing import Type

from .._manager._manager_factory import _ManagerFactory
from ..common._check_dependencies import _TAIPY_ENTERPRISE_CORE_MODULE, _using_enterprise
from ..common._check_dependencies import EnterpriseChecker
from ..common._utils import _load_fct
from ._job_fs_repository import _JobFSRepository
from ._job_manager import _JobManager
Expand All @@ -24,10 +24,12 @@ class _JobManagerFactory(_ManagerFactory):
@classmethod
@lru_cache
def _build_manager(cls) -> Type[_JobManager]:
if _using_enterprise():
job_manager = _load_fct(_TAIPY_ENTERPRISE_CORE_MODULE + ".job._job_manager", "_JobManager") # type: ignore
if EnterpriseChecker._using_enterprise():
job_manager = _load_fct(
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".job._job_manager", "_JobManager"
) # type: ignore
build_repository = _load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + ".job._job_manager_factory", "_JobManagerFactory"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".job._job_manager_factory", "_JobManagerFactory"
)._build_repository # type: ignore
else:
job_manager = _JobManager
Expand Down
9 changes: 5 additions & 4 deletions taipy/core/scenario/_scenario_manager_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from typing import Type

from .._manager._manager_factory import _ManagerFactory
from ..common._check_dependencies import _TAIPY_ENTERPRISE_CORE_MODULE, _using_enterprise
from ..common._check_dependencies import EnterpriseChecker
from ..common._utils import _load_fct
from ._scenario_fs_repository import _ScenarioFSRepository
from ._scenario_manager import _ScenarioManager
Expand All @@ -24,12 +24,13 @@ class _ScenarioManagerFactory(_ManagerFactory):
@classmethod
@lru_cache
def _build_manager(cls) -> Type[_ScenarioManager]:
if _using_enterprise():
if EnterpriseChecker._using_enterprise():
scenario_manager = _load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + ".scenario._scenario_manager", "_ScenarioManager"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".scenario._scenario_manager", "_ScenarioManager"
) # type: ignore
build_repository = _load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + ".scenario._scenario_manager_factory", "_ScenarioManagerFactory"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".scenario._scenario_manager_factory",
"_ScenarioManagerFactory",
)._build_repository # type: ignore
else:
scenario_manager = _ScenarioManager
Expand Down
6 changes: 3 additions & 3 deletions taipy/core/sequence/_sequence_manager_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from typing import Type

from .._manager._manager_factory import _ManagerFactory
from ..common._check_dependencies import _TAIPY_ENTERPRISE_CORE_MODULE, _using_enterprise
from ..common._check_dependencies import EnterpriseChecker
from ..common._utils import _load_fct
from ._sequence_manager import _SequenceManager

Expand All @@ -21,9 +21,9 @@ class _SequenceManagerFactory(_ManagerFactory):
@classmethod
@lru_cache
def _build_manager(cls) -> Type[_SequenceManager]: # type: ignore
if _using_enterprise():
if EnterpriseChecker._using_enterprise():
sequence_manager = _load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + ".sequence._sequence_manager", "_SequenceManager"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".sequence._sequence_manager", "_SequenceManager"
) # type: ignore
else:
sequence_manager = _SequenceManager
Expand Down
9 changes: 5 additions & 4 deletions taipy/core/submission/_submission_manager_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from typing import Type

from .._manager._manager_factory import _ManagerFactory
from ..common._check_dependencies import _TAIPY_ENTERPRISE_CORE_MODULE, _using_enterprise
from ..common._check_dependencies import EnterpriseChecker
from ..common._utils import _load_fct
from ._submission_fs_repository import _SubmissionFSRepository
from ._submission_manager import _SubmissionManager
Expand All @@ -24,12 +24,13 @@ class _SubmissionManagerFactory(_ManagerFactory):
@classmethod
@lru_cache
def _build_manager(cls) -> Type[_SubmissionManager]:
if _using_enterprise():
if EnterpriseChecker._using_enterprise():
submission_manager = _load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + ".submission._submission_manager", "_SubmissionManager"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".submission._submission_manager",
"_SubmissionManager",
) # type: ignore
build_repository = _load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + ".submission._submission_manager_factory",
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".submission._submission_manager_factory",
"_SubmissionManagerFactory",
)._build_repository # type: ignore
else:
Expand Down
10 changes: 6 additions & 4 deletions taipy/core/task/_task_manager_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from typing import Type

from .._manager._manager_factory import _ManagerFactory
from ..common._check_dependencies import _TAIPY_ENTERPRISE_CORE_MODULE, _using_enterprise
from ..common._check_dependencies import EnterpriseChecker
from ..common._utils import _load_fct
from ._task_fs_repository import _TaskFSRepository
from ._task_manager import _TaskManager
Expand All @@ -24,10 +24,12 @@ class _TaskManagerFactory(_ManagerFactory):
@classmethod
@lru_cache
def _build_manager(cls) -> Type[_TaskManager]:
if _using_enterprise():
task_manager = _load_fct(_TAIPY_ENTERPRISE_CORE_MODULE + ".task._task_manager", "_TaskManager") # type: ignore
if EnterpriseChecker._using_enterprise():
task_manager = _load_fct(
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".task._task_manager", "_TaskManager"
) # type: ignore
build_repository = _load_fct(
_TAIPY_ENTERPRISE_CORE_MODULE + ".task._task_manager_factory", "_TaskManagerFactory"
EnterpriseChecker._TAIPY_ENTERPRISE_CORE_MODULE + ".task._task_manager_factory", "_TaskManagerFactory"
)._build_repository # type: ignore
else:
task_manager = _TaskManager
Expand Down

0 comments on commit 79ff677

Please sign in to comment.