Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed documentation for dialog #1147

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixed documentation for dialog #1147

wants to merge 1 commit into from

Conversation

FabienLelaquais
Copy link
Member

Addresses #1115.

Renamed all references to code examples

@FabienLelaquais
Fixed documentation for dialog
71c0891 
Renamed all references to code examples
@FabienLelaquais FabienLelaquais added 🖰 GUI Related to GUI 📄 Documentation Internal or public documentation 💥Malfunction Addresses an identified problem. 🟧 Priority: High Stalls work on the project or its dependents labels Oct 3, 2024
@FabienLelaquais FabienLelaquais self-assigned this Oct 3, 2024
FredLL-Avaiga
FredLL-Avaiga approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose I'm wrong about taipy-date_range but it looks really weird... I suppose for 5.0 :-)
Well done
Quite a job

docs/refmans/gui/viselements/generic/date_range.md_template

# Styling

All the date range controls are generated with the "taipy-date_range" CSS class. You can use this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo taipy-date_range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredLL-Avaiga FredLL-Avaiga FredLL-Avaiga approved these changes

@namnguyen20999 namnguyen20999 Awaiting requested review from namnguyen20999

@dinhlongviolin1 dinhlongviolin1 Awaiting requested review from dinhlongviolin1

Assignees

@FabienLelaquais FabienLelaquais

Labels
📄 Documentation Internal or public documentation 🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟧 Priority: High Stalls work on the project or its dependents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabienLelaquais @FredLL-Avaiga