Tests for possible fatal errors when getting order #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting PR per support request
Description
Encountered in the wild, I found an issue where fatal PHP errors could be thrown from class-wcs-cart-renewal on line 1314 and wcs-renewal-functions on line 112.
This resulted in one customer in particular encountering a fatal error on all page requests immediately after logging in.
PHP Fatal error: Uncaught Error: Call to a member function get_fees() on bool in
/wp-content/plugins/woocommerce-subscriptions/vendor/woocommerce/subscriptions-core/includes/class-wcs-cart-renewal.php:1314
PHP Fatal error: Uncaught Error: Call to a member function has_status() on bool in
/wp-content/plugins/woocommerce-subscriptions/vendor/woocommerce/subscriptions-core/includes/wcs-renewal-functions.php:112
The submitted change checks that an order is preset before attempting to call methods that would result in a 500 error if the order is false.
How to test this PR
How to replicate the apparent issue with a past order isn't known but suspect it was due to a manual deletion or cancellation of a past subscription via the admin.
Tested the patch live on the site which had this problem by signing in as that user, used the site as normal, no other issues found.