Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer validation and spacing issue #8208

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

richtabor
Copy link
Contributor

@richtabor richtabor commented Sep 26, 2024

Resolve the block validation issue within the Assembler's footer template part.

Content generated by `save` function:

<h2 class="wp-block-heading has-text-align-center">Hours</h2>

Content retrieved from post body:

<h3 class="wp-block-heading has-text-align-center">Hours</h3>

Before

CleanShot 2024-09-26 at 14 56 40

After

CleanShot 2024-09-26 at 14 56 24

@richtabor richtabor added [Type] Bug Something isn't working [Theme] Assembler labels Sep 26, 2024
@richtabor richtabor self-assigned this Sep 26, 2024
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Assembler.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

Theme-Check results

assembler: No changes required ✅.


@alaczek
Copy link
Contributor

alaczek commented Sep 27, 2024

👍 LGTM

@alaczek alaczek merged commit be9c864 into trunk Sep 27, 2024
5 checks passed
@alaczek alaczek deleted the fix/assembler/footer branch September 27, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Assembler [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants