Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streamer #8150

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Add streamer #8150

wants to merge 1 commit into from

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

Related issue(s):

@scruffian scruffian added the Ready to launch Add this label if this is the first PR for a new theme label Sep 13, 2024
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Streamer.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@matiasbenedetto matiasbenedetto added Ready to launch Add this label if this is the first PR for a new theme and removed Ready to launch Add this label if this is the first PR for a new theme labels Sep 17, 2024
Copy link
Contributor

Theme-Check results

streamer: There are required changes on the theme ❌.

❎ REQUIRED

  • Both DOS and UNIX style line endings were found in the file readme.txt. This causes a problem with SVN repositories and must be corrected before the theme can be accepted. Please change the file to use only one style of line endings.
  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
  • This theme text domain does not match the theme's slug. The text domain used: wordpresscom-theme-updates This theme's correct slug and text-domain is streamer.
💡 RECOMMENDED (3)
  • No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • Tested up to is recommended to have major versions only (e.g. 5.8). Patch version is not needed (e.g. 5.8.1).
⚠️ WARNING (2)
  • assets/images/andre-hunter-ugjPgy2BQug-unsplash.jpg is 663.1 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
  • screenshot.png is 822.4 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
ℹ️ INFO (11)
  • Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/
  • Found wrong tag, remove Esports from your style.css header.
  • Found wrong tag, remove Gaming from your style.css header.
  • Found wrong tag, remove videogames from your style.css header.
  • Found wrong tag, remove esports-squad from your style.css header.
  • Found wrong tag, remove squad from your style.css header.
  • Found wrong tag, remove community-hub from your style.css header.
  • Found wrong tag, remove store from your style.css header.
  • Found wrong tag, remove Esports-Experience from your style.css header.
  • Found wrong tag, remove Tournaments from your style.css header.
  • Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs. The domain found is wordpresscom-theme-updates.

@henriqueiamarino henriqueiamarino marked this pull request as draft September 24, 2024 11:39
@henriqueiamarino henriqueiamarino self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants