Sitemap: Make sitemap storing more efficient by not querying the full post content before saving

[oskosk]

This update tries to remediate a problem where the persistent object cache gets big with data that we will not use in the end.

We just need to get the id of the current sitemap post and if it exists, we update it.

Before, we were using get_post() and this polluted the cache running into OOM situations

In p9F6qB-g4Y-p2#comment-62552 it's noted that the current behavior is not efficient.

Note: this PR may need a follow-up cause there's further investigation in p9F6qB-g4Y-p2#comment-62583

Proposed changes:

• Introduced functionget_current_sitemap_post_id()
• Updates store_sitemap_data() to use get_current_sitemap_post_id().

Jetpack product discussion

p9F6qB-g4Y-p2#comment-62552

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• On a connected site (Launch one with Jurassic Ninja and this branch), confirm the sitemap functionality is enabled under Jetpack → Settings → Traffic.
• checkout this branch git checkout update/sitemap-store-more-efficiently
• Navigate to your sitemap (typically at /sitemap.xml), and click the first one.
• Verify that all current content types (posts, pages, etc.) are correctly listed in the sitemap.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/sitemap-store-more-efficiently branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/sitemap-store-more-efficiently
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for October 1, 2024 (scheduled code freeze on September 30, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.