Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterbar: Remove User Info side-panel #39546

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

fgiannar
Copy link
Contributor

@fgiannar fgiannar commented Sep 26, 2024

Now that the masterbar module has been removed from self-hosted sites via #39406, we can wrap up the work done in #35199
In that PR, the User Info and My Sites side-panels were removed however the PR had to be reverted as it introduced unwanted behaviour in self-hosted sites. See: p9Jlb4-R8-p2
Note that the task of removing the My Sites side-panel is already done via #37764
Therefore, this PR addresses the part of removing the User Info side panel

Proposed changes:

  • Automattic\Jetpack\Masterbar\Masterbar: Update add_me_submenu by removing sub-menu items.
  • Automattic\Jetpack\Masterbar\Masterbar: Cleanup unused code in add_my_sites_submenu.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pfwV0U-3U-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Confirm that clicking on the user account icon in the top bar menu behaves the same on trunk/branch on:

  • Self hosted sites
  • WoA sites with admin interface set to 1) Classic and 2) Default
  • Simple sites with admin interface set to 1) Classic and 2) Default

Finally, as per the corresponding reported issue in p9Jlb4-R8-p2 lets make sure that the left drawer is visible on mobile view (in all the above envs):

Screenshot 2024-09-27 at 14 43 26

@fgiannar fgiannar self-assigned this Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/masterbar-remove-user-info-sidepanel branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/masterbar-remove-user-info-sidepanel
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/masterbar-remove-user-info-sidepanel
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Masterbar labels Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 26, 2024
@fgiannar fgiannar added [Status] In Progress [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] In Progress labels Sep 26, 2024
@fgiannar fgiannar requested review from a team and jeherve September 27, 2024 09:20
Copy link
Contributor

@darssen darssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping Jetpack tidy ❤️

Not familiar with the flow, but I tested all the different environments and did not see any changes in behavior. Also, no errors or console logs did appear.

Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, tested the different environments and noticed no differences, looks good. 🚢

@fgiannar fgiannar merged commit 0c6a95a into trunk Sep 30, 2024
65 of 67 checks passed
@fgiannar fgiannar deleted the update/masterbar-remove-user-info-sidepanel branch September 30, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Masterbar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants