-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masterbar: Remove User Info side-panel #39546
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping Jetpack tidy ❤️
Not familiar with the flow, but I tested all the different environments and did not see any changes in behavior. Also, no errors or console logs did appear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, tested the different environments and noticed no differences, looks good. 🚢
Now that the
masterbar
module has been removed from self-hosted sites via #39406, we can wrap up the work done in #35199In that PR, the User Info and My Sites side-panels were removed however the PR had to be reverted as it introduced unwanted behaviour in self-hosted sites. See: p9Jlb4-R8-p2
Note that the task of removing the My Sites side-panel is already done via #37764
Therefore, this PR addresses the part of removing the User Info side panel
Proposed changes:
Automattic\Jetpack\Masterbar\Masterbar
: Updateadd_me_submenu
by removing sub-menu items.Automattic\Jetpack\Masterbar\Masterbar
: Cleanup unused code inadd_my_sites_submenu
.Other information:
Jetpack product discussion
pfwV0U-3U-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Confirm that clicking on the user account icon in the top bar menu behaves the same on trunk/branch on:
Finally, as per the corresponding reported issue in p9Jlb4-R8-p2 lets make sure that the left drawer is visible on mobile view (in all the above envs):