Update cake tools #2293
Draft
Update cake tools #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
martincostello
commented
Sep 17, 2024
•
martincostello
commented
- Bump xunit.runner.console to 2.9.1.
- Bump dotnet-stryker to 4.2.0.
- Bump xunit.runner.console to 2.9.0. - Bump dotnet-stryker to 4.2.0.
martincostello
added
CI/build
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
==========================================
+ Coverage 85.35% 85.38% +0.02%
==========================================
Files 313 313
Lines 7444 7457 +13
Branches 1122 1123 +1
==========================================
+ Hits 6354 6367 +13
Misses 745 745
Partials 345 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Needs more mutants. |
- Remove redundant branch because when the key is null it uses the default key, which is what `CurrentValue` does anyway. - Assert that the correct options instance is retrieved.
martincostello
commented
Sep 18, 2024
| @@ -61,8 +61,7 @@ internal AddResiliencePipelineContext(ConfigureBuilderContext<TKey> registryCont | |||
| public TOptions GetOptions<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] TOptions>(string? name = null) | |||
| { | |||
| var monitor = ServiceProvider.GetRequiredService<IOptionsMonitor<TOptions>>(); | |||
|
|
|||
| return name == null ? monitor.CurrentValue : monitor.Get(name); | |||
| return monitor.Get(name); | |||
There was a problem hiding this comment.
Effectively duplicates the implementation the way it was.
Rename property to fix Name being overwritten.
- Start with the newest to see if that fixes Stryker. - Explicitly target Debug for mutation tests. - Add missing `eng` items to the Solution Items.
Enable dev mode for Stryker to try and work out why Polly.Specs mutation tests are failing.
Can only be enabled on the command-line, not in the configuration file.
Remove `true`.
Include logs from Stryker in the mutation reports.
It's a flag, not an option that you give a path...
See if stryker will work it out for itself.
Revert changes made to try and get Stryker working as it's been confirmed there's a bug.
Update xunit.runner.console to 2.9.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.