feat: Ability to override commands args #619
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to override the arguments which are used e.g. to call smartctl, they need to be bind to the respective environment variable.
|
Hopefully this will fix #221 |
AnalogJ
reviewed
Apr 5, 2024
Comment on lines
+51
to
+60
| // Bind environment variables with COLLECTOR_ prefix | ||
| c.BindEnv("host.id", "COLLECTOR_HOST_ID") | ||
| c.BindEnv("log.level", "COLLECTOR_LOG_LEVEL") | ||
| c.BindEnv("log.file", "COLLECTOR_LOG_FILE") | ||
| c.BindEnv("api.endpoint", "COLLECTOR_API_ENDPOINT") | ||
| c.BindEnv("commands.metrics_smartctl_bin", "COLLECTOR_COMMANDS_METRICS_SMARTCTL_BIN") | ||
| c.BindEnv("commands.metrics_scan_args", "COLLECTOR_COMMANDS_METRICS_SCAN_ARGS") | ||
| c.BindEnv("commands.metrics_info_args", "COLLECTOR_COMMANDS_METRICS_INFO_ARGS") | ||
| c.BindEnv("commands.metrics_smart_args", "COLLECTOR_COMMANDS_METRICS_SMART_ARGS") | ||
|
|
There was a problem hiding this comment.
Suggested change
| // Bind environment variables with COLLECTOR_ prefix | |
| c.BindEnv("host.id", "COLLECTOR_HOST_ID") | |
| c.BindEnv("log.level", "COLLECTOR_LOG_LEVEL") | |
| c.BindEnv("log.file", "COLLECTOR_LOG_FILE") | |
| c.BindEnv("api.endpoint", "COLLECTOR_API_ENDPOINT") | |
| c.BindEnv("commands.metrics_smartctl_bin", "COLLECTOR_COMMANDS_METRICS_SMARTCTL_BIN") | |
| c.BindEnv("commands.metrics_scan_args", "COLLECTOR_COMMANDS_METRICS_SCAN_ARGS") | |
| c.BindEnv("commands.metrics_info_args", "COLLECTOR_COMMANDS_METRICS_INFO_ARGS") | |
| c.BindEnv("commands.metrics_smart_args", "COLLECTOR_COMMANDS_METRICS_SMART_ARGS") | |
| // Bind environment variables with COLLECTOR_ prefix | |
| c.SetEnvPrefix("COLLECTOR") |
I think that should work instead. Can you test and confirm @datenzar ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to override the arguments which are used e.g. to call smartctl, they need to be bind to the respective environment variable.