Use traversal abstraction #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiagrammaticEquations.jl PRs 69 and 70 demonstrate means of traversing a SummationDecapode object, and returning a cached record of topologically-sorted operations.
This current PR demonstrates how this means can be used to re-organize code which “visits” such operations and emits code. For the purposes of this PR, whether DiagrammaticEquations returns a (lazy) iterator over a SummationDecapode or a collected version of such is abstracted away.
It also takes the opportunity to make minor modifications to the rules around when certain operations can be broadcasted.
Tests pass using commit dfe0e03 of DiagrammaticEquations’
llm/fwbranch.