Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abris add installation documentation #356

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

cerveada
Copy link
Collaborator

@cerveada cerveada commented Feb 13, 2024

add documentation describing the need for spark-avro.

Copy link

JaCoCo code coverage report

There is no coverage information present for the Files changed

Total Project Coverage 81.69% 🍏

@cerveada
Copy link
Collaborator Author

the spark-avro dependency could be provided or optional. I am still not sure if it would be better or not.

<dependency>
<groupId>za.co.absa</groupId>
<artifactId>abris_2.12</artifactId>
<version>6.4.0</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add an exclusion here, just to be sure

README.md Outdated
Example: submitting a Spark job:
```
./bin/spark-submit \
--packages org.apache.spark:spark-avro_2.12:3.5.0,za.co.absa:abris_2.12:6.2.0 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--packages org.apache.spark:spark-avro_2.12:3.5.0,za.co.absa:abris_2.12:6.2.0 \
--packages org.apache.spark:spark-avro_2.12:3.5.0,za.co.absa:abris_2.12:6.4.0 \

<artifactId>abris_2.12</artifactId>
<version>6.4.0</version>
</dependency>
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could also add documentation for sbt

@cerveada cerveada merged commit 416c4a3 into master Feb 22, 2024
11 checks passed
@kevinwallimann kevinwallimann deleted the feature/installation-documentation branch April 29, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants