Replace windows-sys with windows-bindgen #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sys-locale only uses 3 definitions from Windows, which makes the windows-sys dependency not worthwhile
complexspaces
force-pushed
the
windows-dep-changes
branch
from
5b5baea
to
df58bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today,
sys-localeonly uses 3 definitions from Windows, and that is unlikely to change a lot given the crate's current narrow scoping. Given that, thewindows-sysdependency isn't worthwhile to have anymore especially with its version churn.Instead, we can adopt Microsoft's official bindings generator,
riddle/windows-bindgen, to get the few APIs required.