Reset layout data in rss.md example #1626
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried copy-pasting this example, and when I entered my output feed.xml file into the validator, I got an error: > It looks like this is a web page, not a feed. I looked for a feed associated with this page, but couldn't find one. Please enter the address of your feed to validate. I realized that what was happening was that my data cascade was applying a layout that wrapped the XML tag in my default HTML layout. I've changed the example .njk file to add a line in the front matter that resets any layout data from the cascade. Another option would be to add a warning or clarification to the text, but I thought this seemed like a straightforward way to prevent future readers from making my mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried copy-pasting this example, and when I entered my output feed.xml file into the validator, I got an error:
I realized that what was happening was that my data cascade was applying a layout that wrapped the XML tag in my default HTML layout.
I've changed the example .njk file to add a line in the front matter that resets any layout data from the cascade.
Another option would be to add a warning or clarification to the text, but I thought this seemed like a straightforward way to prevent future readers from making my mistake.