Add removal of the gzipped binaries in the gem native extension build step #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem native extension build step
|
@tioteath I get two warnings when running bundle: Otherwise it works great, also on Heroku. Thanks! It appears it is not even necessary to set WKHTMLTOPDF_GEM_MINIMIZE, because my slug size on Heroku reduced greatly even without this env var. Does anyone know why this PR isn't getting merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Added code which removes gzipped binaries from the
bindirectory during gem native extension build step. This allows to reduce a footprint of the installed gem from almost 280MB to about 47MB.I have tested it on
Ubuntu Bionic 18.04,Ubuntu Focal 20.04andDebian Buster 10.fixes #55