Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalSettings.update_global_settings raises JSONDecodeError #102

Open
jjeffryes-shippo opened this issue Feb 29, 2024 · 0 comments
Open
Labels

Comments

@jjeffryes-shippo
Copy link

Proposal

It appears that GlobalSettings.update_global_settings() expects to receive back the updated setting when posting to __admin/settings but according to the documentation the actual successful response is blank. Thus when I attempt this, the setting is successfully applied but raises a JSONDecodeError from requests.

Reproduction steps

Based on the unit test I see here, I attempted to set a global fixed delay as follows:
GlobalSettings.update_global_settings(GlobalSetting(fixed_delay=350)) with wiremock:2.32.0.

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant