Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more clojure.core functions #10

Open
8 of 14 tasks
vickychijwani opened this issue Dec 30, 2014 · 5 comments
Open
8 of 14 tasks

Implement more clojure.core functions #10

vickychijwani opened this issue Dec 30, 2014 · 5 comments

Comments

@vickychijwani
Copy link
Owner

Closer.js currently supports more than 100 functions from clojure.core, but we need to add more to this collection. If someone wants to contribute, feel free to dive in! This is a great place to start contributing. Since we get a lot of free functionality from Mori, many functions become easy to implement.

Steps to add a new function:

Here's an initial list of missing functions that should be simple to implement (there are many others missing):

Please leave a comment here stating which functions you're going to tackle before you start working, so others don't end up duplicating your work and vice versa.

@prakhar1989
Copy link

This is awesome! Will send a PR soon 😀

@koustuvsinha
Copy link
Contributor

@vickychijwani Will I add one PR for every function or consolidate a few?

@vickychijwani
Copy link
Owner Author

@koustuvsinha I'm fine with any number of functions per PR as long as they're in separate commits.

@koustuvsinha
Copy link
Contributor

Ok. Implemented distinct and rand-nth, now will do the following :

  • frequencies
  • get-in
  • assoc-in

@koustuvsinha
Copy link
Contributor

Working on the following :

  • not-every?
  • not-any?
  • distinct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants