Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yamux: Remove trySend AsyncSpawn #1134

Closed
lchenut opened this issue Jun 21, 2024 · 1 comment
Closed

Yamux: Remove trySend AsyncSpawn #1134

lchenut opened this issue Jun 21, 2024 · 1 comment
Assignees
@lchenut

Comments

@lchenut
Copy link
Collaborator

lchenut commented Jun 21, 2024 •
edited
Loading

AsyncSpawn, in this specific case is clearly overkill. AsyncSpawn is not recommended as it is uncontrollable, and, here, it could easily be replaced by another method which is safer such as an AsyncQueue or just storing the Future in the Yamux object.
@lchenut lchenut self-assigned this Jun 21, 2024
@lchenut lchenut mentioned this issue Jun 26, 2024
Closed
@lchenut
Copy link
Collaborator Author

lchenut commented Aug 5, 2024

#1163 override this issue.

@lchenut lchenut closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lchenut lchenut

Labels
None yet
Projects
nim-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(yamux): remove asyncSpawn vacp2p/nim-libp2p
1 participant
@lchenut