Failure during catalog upsert leads to inconsistent state

[piotrrzysko]

In CoordinatorDynamicCatalogManager, when a new catalog is created, the in-memory map storing active catalogs is updated before calling CatalogStore to upsert the catalog:

trino/core/trino-main/src/main/java/io/trino/connector/CoordinatorDynamicCatalogManager.java

Lines 279 to 280 in db35155

	activeCatalogs.put(catalogName, catalog.getCatalog());
	catalogStore.addOrReplaceCatalog(catalogProperties);

If the upsert fails (for example, if FileCatalogStore throws an exception due to an inability to store the catalog's properties), the catalog is still considered active, even though it hasn't been persisted.

[hashhar]

FYI @dain. We'll propose a fix and send a PR for this soon.