Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timed out tasks requeue #53

Open
chrisdoherty4 opened this issue Jul 15, 2022 · 0 comments
Open

Timed out tasks requeue #53

chrisdoherty4 opened this issue Jul 15, 2022 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/low

Comments

@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Jul 15, 2022

When Rufio times out a task it returns an error from the reconciliation request resulting in an unnecessary requeue.

Instead, we expect the controller to patch the status, log the error and return nothing preventing the requeue.

This isn't hugely impactful as the controller identifies the task as failed and noops on the subsequent reconciliation.
See https://github.com/tinkerbell/rufio/blob/main/controllers/task_controller.go#L133

@chrisdoherty4 chrisdoherty4 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 15, 2022
@chrisdoherty4 chrisdoherty4 changed the title Timed out tasks continuously requeue Timed out tasks requeue Jul 15, 2022
@chrisdoherty4 chrisdoherty4 added this to the 0.2 milestone Jul 15, 2022
@chrisdoherty4 chrisdoherty4 modified the milestones: v0.2, v0.3 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/low
Projects
None yet
Development

No branches or pull requests

1 participant