Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scale from visualization marker base class #614

Open
marip8 opened this issue Jun 23, 2021 · 0 comments
Open

Remove scale from visualization marker base class #614

marip8 opened this issue Jun 23, 2021 · 0 comments

Comments

@marip8
Copy link
Contributor

marip8 commented Jun 23, 2021

The tesseract_visualization::Marker base class currently has a scale_ parameter that seems to control the size of some markers.

https://github.com/ros-industrial-consortium/tesseract/blob/3857b5252b9fc1fb9de6de976ac6733799fa476e/tesseract_visualization/include/tesseract_visualization/markers/marker.h#L139-L145

However, most markers (tool path, axis, arrow) have their own parameters for defining how large the objects are. In the case of the tool path marker, the tool path specific scale parameter, not the base class scale, is used to determine how large the waypoint axes are (see here). It seems like the size of an object should be a property of the visualization implementation, so I would propose removing the scale_ parameter from the base class. @Levi-Armstrong is there a case for not removing it from the base class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant