Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can TesseractCompoundCollisionAlgorithm and TesseractCompoundCompoundCollisionAlgorithm be removed? #1005

Open
rjoomen opened this issue May 30, 2024 · 3 comments

Comments

@rjoomen
Copy link
Contributor

rjoomen commented May 30, 2024

I noticed TesseractCompoundCollisionAlgorithm misses some old bugfixes from btCompoundCollisionAlgorithm. I could easily add those to Tesseract, but I noticed that both TesseractCompoundCollisionAlgorithm and TesseractCompoundCompoundCollisionAlgorithm say they could be removed (here and here). Is this already the case? I'm not entirely sure what would be required for that.
In my testing Trajopt ran fine with those removed and even the TesseractConvexConvexAlgorithm removed (although the latter one has modifications important to OMPL planning speed and should not be removed).

@Levi-Armstrong
Copy link
Contributor

It will run fine but these were added for performance reason to allow exiting collision checking faster in the event you wanted to collision to terminator of the first contact found. A PR would need to be made against bullet updating the callback to avoid needing these classes. I think the best option is to port the bug fixes and create an MR updating the callback interface.

@rjoomen
Copy link
Contributor Author

rjoomen commented May 30, 2024

Thanks for explaining. I can do that, but can you point me to where/how the callback interface has to be updated?
In the meantime I'll port the bugfixes.

@rjoomen
Copy link
Contributor Author

rjoomen commented May 31, 2024

Bugfix: #1008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants