forked from uber/tchannel-go
-
Notifications
You must be signed in to change notification settings - Fork 3
/
connection_test.go
1467 lines (1222 loc) · 48.7 KB
/
connection_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright (c) 2015 Uber Technologies, Inc.
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
package tchannel_test
import (
"errors"
"fmt"
"io"
"math"
"net"
"runtime"
"strings"
"sync"
"testing"
"time"
"github.com/temporalio/tchannel-go"
"github.com/temporalio/tchannel-go/raw"
"github.com/temporalio/tchannel-go/relay/relaytest"
"github.com/temporalio/tchannel-go/testutils"
"github.com/temporalio/tchannel-go/testutils/testreader"
"github.com/temporalio/tchannel-go/tos"
"github.com/temporalio/tchannel-go/typed"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"golang.org/x/net/context"
"golang.org/x/net/ipv4"
"golang.org/x/net/ipv6"
)
// Values used in tests
const (
inbound = 0
outbound = 1
)
var (
testArg2 = []byte("Header in arg2")
testArg3 = []byte("Body in arg3")
)
type testHandler struct {
sync.Mutex
t testing.TB
format tchannel.Format
caller string
blockErr chan error
}
func newTestHandler(t testing.TB) *testHandler {
return &testHandler{t: t, blockErr: make(chan error, 1)}
}
func (h *testHandler) Handle(ctx context.Context, args *raw.Args) (*raw.Res, error) {
h.Lock()
h.format = args.Format
h.caller = args.Caller
h.Unlock()
assert.Equal(h.t, args.Caller, tchannel.CurrentCall(ctx).CallerName())
switch args.Method {
case "block":
<-ctx.Done()
h.blockErr <- ctx.Err()
return &raw.Res{
IsErr: true,
}, nil
case "echo":
return &raw.Res{
Arg2: args.Arg2,
Arg3: args.Arg3,
}, nil
case "busy":
return &raw.Res{
SystemErr: tchannel.ErrServerBusy,
}, nil
case "app-error":
return &raw.Res{
IsErr: true,
}, nil
}
return nil, errors.New("unknown method")
}
func (h *testHandler) OnError(ctx context.Context, err error) {
stack := make([]byte, 4096)
runtime.Stack(stack, false /* all */)
h.t.Errorf("testHandler got error: %v stack:\n%s", err, stack)
}
func writeFlushStr(w tchannel.ArgWriter, d string) error {
if _, err := io.WriteString(w, d); err != nil {
return err
}
return w.Flush()
}
func isTosPriority(c net.Conn, tosPriority tos.ToS) (bool, error) {
var connTosPriority int
var err error
switch ip := c.RemoteAddr().(*net.TCPAddr).IP; {
case ip.To16() != nil && ip.To4() == nil:
connTosPriority, err = ipv6.NewConn(c).TrafficClass()
case ip.To4() != nil:
connTosPriority, err = ipv4.NewConn(c).TOS()
}
return connTosPriority == int(tosPriority), err
}
func getErrorFrame(t testing.TB) *tchannel.Frame {
var errFrame *tchannel.Frame
server := testutils.NewServer(t, testutils.NewOpts().DisableLogVerification())
defer server.Close()
frameRelay, cancel := testutils.FrameRelay(t, server.PeerInfo().HostPort, func(outgoing bool, f *tchannel.Frame) *tchannel.Frame {
if strings.Contains(f.Header.String(), "Error") {
errFrame = f
}
return f
})
defer cancel()
testutils.CallEcho(server, frameRelay, "unknown", nil)
require.NotNil(t, errFrame, "Failed to get error frame")
return errFrame
}
func TestRoundTrip(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
handler := newTestHandler(t)
ts.Register(raw.Wrap(handler), "echo")
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
call, err := ts.Server().BeginCall(ctx, ts.HostPort(), ts.ServiceName(), "echo", &tchannel.CallOptions{Format: tchannel.JSON})
require.NoError(t, err)
assert.NotEmpty(t, call.RemotePeer().HostPort)
assert.Equal(t, ts.Server().PeerInfo(), call.LocalPeer(), "Unexpected local peer")
require.NoError(t, tchannel.NewArgWriter(call.Arg2Writer()).Write(testArg2))
require.NoError(t, tchannel.NewArgWriter(call.Arg3Writer()).Write(testArg3))
var respArg2 []byte
require.NoError(t, tchannel.NewArgReader(call.Response().Arg2Reader()).Read(&respArg2))
assert.Equal(t, testArg2, []byte(respArg2))
var respArg3 []byte
require.NoError(t, tchannel.NewArgReader(call.Response().Arg3Reader()).Read(&respArg3))
assert.Equal(t, testArg3, []byte(respArg3))
assert.Equal(t, tchannel.JSON, handler.format)
assert.Equal(t, ts.ServiceName(), handler.caller)
assert.Equal(t, tchannel.JSON, call.Response().Format(), "response Format should match request Format")
})
}
func TestDefaultFormat(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
handler := newTestHandler(t)
ts.Register(raw.Wrap(handler), "echo")
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
arg2, arg3, resp, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "echo", testArg2, testArg3)
require.Nil(t, err)
require.Equal(t, testArg2, arg2)
require.Equal(t, testArg3, arg3)
require.Equal(t, tchannel.Raw, handler.format)
assert.Equal(t, tchannel.Raw, resp.Format(), "response Format should match request Format")
})
}
func TestRemotePeer(t *testing.T) {
wantVersion := tchannel.PeerVersion{
Language: "go",
LanguageVersion: strings.TrimPrefix(runtime.Version(), "go"),
TChannelVersion: tchannel.VersionInfo,
}
tests := []struct {
name string
remote func(testing.TB, *testutils.TestServer) *tchannel.Channel
expectedFn func(*tchannel.RuntimeState, *testutils.TestServer) tchannel.PeerInfo
}{
{
name: "ephemeral client",
remote: func(t testing.TB, ts *testutils.TestServer) *tchannel.Channel { return ts.NewClient(nil) },
expectedFn: func(state *tchannel.RuntimeState, ts *testutils.TestServer) tchannel.PeerInfo {
return tchannel.PeerInfo{
HostPort: state.RootPeers[ts.HostPort()].OutboundConnections[0].LocalHostPort,
IsEphemeral: true,
ProcessName: state.LocalPeer.ProcessName,
Version: wantVersion,
}
},
},
{
name: "listening server",
remote: func(t testing.TB, ts *testutils.TestServer) *tchannel.Channel { return ts.NewServer(nil) },
expectedFn: func(state *tchannel.RuntimeState, ts *testutils.TestServer) tchannel.PeerInfo {
return tchannel.PeerInfo{
HostPort: state.LocalPeer.HostPort,
IsEphemeral: false,
ProcessName: state.LocalPeer.ProcessName,
Version: wantVersion,
}
},
},
}
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
for _, tt := range tests {
opts := testutils.NewOpts().SetServiceName("fake-service").NoRelay()
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
remote := tt.remote(t, ts)
defer remote.Close()
gotPeer := make(chan tchannel.PeerInfo, 1)
ts.RegisterFunc("test", func(ctx context.Context, args *raw.Args) (*raw.Res, error) {
gotPeer <- tchannel.CurrentCall(ctx).RemotePeer()
assert.Equal(t, ts.Server().PeerInfo(), tchannel.CurrentCall(ctx).LocalPeer())
return &raw.Res{}, nil
})
_, _, _, err := raw.Call(ctx, remote, ts.HostPort(), ts.Server().ServiceName(), "test", nil, nil)
assert.NoError(t, err, "%v: Call failed", tt.name)
expected := tt.expectedFn(remote.IntrospectState(nil), ts)
assert.Equal(t, expected, <-gotPeer, "%v: RemotePeer mismatch", tt.name)
})
}
}
func TestReuseConnection(t *testing.T) {
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
// Since we're specifically testing that connections between hosts are re-used,
// we can't interpose a relay in this test.
s1Opts := testutils.NewOpts().SetServiceName("s1").NoRelay()
testutils.WithTestServer(t, s1Opts, func(t testing.TB, ts *testutils.TestServer) {
ch2 := ts.NewServer(&testutils.ChannelOpts{ServiceName: "s2"})
hostPort2 := ch2.PeerInfo().HostPort
defer ch2.Close()
ts.Register(raw.Wrap(newTestHandler(t)), "echo")
ch2.Register(raw.Wrap(newTestHandler(t)), "echo")
outbound, err := ts.Server().BeginCall(ctx, hostPort2, "s2", "echo", nil)
require.NoError(t, err)
outboundConn, outboundNetConn := tchannel.OutboundConnection(outbound)
// Try to make another call at the same time, should reuse the same connection.
outbound2, err := ts.Server().BeginCall(ctx, hostPort2, "s2", "echo", nil)
require.NoError(t, err)
outbound2Conn, _ := tchannel.OutboundConnection(outbound)
assert.Equal(t, outboundConn, outbound2Conn)
// Wait for the connection to be marked as active in ch2.
assert.True(t, testutils.WaitFor(time.Second, func() bool {
return ch2.IntrospectState(nil).NumConnections > 0
}), "ch2 does not have any active connections")
// When ch2 tries to call the test server, it should reuse the existing
// inbound connection the test server. Of course, this only works if the
// test server -> ch2 call wasn't relayed.
outbound3, err := ch2.BeginCall(ctx, ts.HostPort(), "s1", "echo", nil)
require.NoError(t, err)
_, outbound3NetConn := tchannel.OutboundConnection(outbound3)
assert.Equal(t, outboundNetConn.RemoteAddr(), outbound3NetConn.LocalAddr())
assert.Equal(t, outboundNetConn.LocalAddr(), outbound3NetConn.RemoteAddr())
// Ensure all calls can complete in parallel.
var wg sync.WaitGroup
for _, call := range []*tchannel.OutboundCall{outbound, outbound2, outbound3} {
wg.Add(1)
go func(call *tchannel.OutboundCall) {
defer wg.Done()
resp1, resp2, _, err := raw.WriteArgs(call, []byte("arg2"), []byte("arg3"))
require.NoError(t, err)
assert.Equal(t, resp1, []byte("arg2"), "result does match argument")
assert.Equal(t, resp2, []byte("arg3"), "result does match argument")
}(call)
}
wg.Wait()
})
}
func TestPing(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
errFrame := getErrorFrame(t)
var returnErr bool
frameRelay, close := testutils.FrameRelay(t, ts.HostPort(), func(outgoing bool, f *tchannel.Frame) *tchannel.Frame {
if !outgoing && returnErr {
errFrame.Header.ID = f.Header.ID
f = errFrame
}
return f
})
defer close()
clientCh := ts.NewClient(nil)
defer clientCh.Close()
require.NoError(t, clientCh.Ping(ctx, frameRelay))
conn, err := clientCh.RootPeers().GetOrAdd(frameRelay).GetConnection(ctx)
require.NoError(t, err, "Failed to get connection")
returnErr = true
require.Error(t, conn.Ping(ctx), "Expect error from error frame")
require.True(t, conn.IsActive(), "Connection should still be active after error frame")
returnErr = false
require.NoError(t, conn.Ping(ctx), "Ping should succeed")
})
}
func TestBadRequest(t *testing.T) {
// ch will log an error when it receives a request for an unknown handler.
opts := testutils.NewOpts().AddLogFilter("Couldn't find handler.", 1)
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "Noone", []byte("Headers"), []byte("Body"))
require.NotNil(t, err)
assert.Equal(t, tchannel.ErrCodeBadRequest, tchannel.GetSystemErrorCode(err))
calls := relaytest.NewMockStats()
calls.Add(ts.ServiceName(), ts.ServiceName(), "Noone").Failed("bad-request").End()
ts.AssertRelayStats(calls)
})
}
func TestNoTimeout(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ts.Register(raw.Wrap(newTestHandler(t)), "Echo")
ctx := context.Background()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), "svc", "Echo", []byte("Headers"), []byte("Body"))
assert.Equal(t, tchannel.ErrTimeoutRequired, err)
ts.AssertRelayStats(relaytest.NewMockStats())
})
}
func TestCancelled(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ts.Register(raw.Wrap(newTestHandler(t)), "echo")
ctx, cancel := tchannel.NewContext(time.Second)
// Make a call first to make sure we have a connection.
// We want to test the BeginCall path.
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "echo", []byte("Headers"), []byte("Body"))
assert.NoError(t, err, "Call failed")
// Now cancel the context.
cancel()
_, _, _, err = raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "echo", []byte("Headers"), []byte("Body"))
assert.Equal(t, tchannel.ErrRequestCancelled, err, "Unexpected error when making call with canceled context")
})
}
func TestNoServiceNaming(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), "", "Echo", []byte("Headers"), []byte("Body"))
assert.Equal(t, tchannel.ErrNoServiceName, err)
ts.AssertRelayStats(relaytest.NewMockStats())
})
}
func TestServerBusy(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ts.Register(tchannel.ErrorHandlerFunc(func(ctx context.Context, call *tchannel.InboundCall) error {
if _, err := raw.ReadArgs(call); err != nil {
return err
}
return tchannel.ErrServerBusy
}), "busy")
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "busy", []byte("Arg2"), []byte("Arg3"))
require.NotNil(t, err)
assert.Equal(t, tchannel.ErrCodeBusy, tchannel.GetSystemErrorCode(err), "err: %v", err)
calls := relaytest.NewMockStats()
calls.Add(ts.ServiceName(), ts.ServiceName(), "busy").Failed("busy").End()
ts.AssertRelayStats(calls)
})
}
func TestUnexpectedHandlerError(t *testing.T) {
opts := testutils.NewOpts().
AddLogFilter("Unexpected handler error", 1)
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
ts.Register(tchannel.ErrorHandlerFunc(func(ctx context.Context, call *tchannel.InboundCall) error {
if _, err := raw.ReadArgs(call); err != nil {
return err
}
return fmt.Errorf("nope")
}), "nope")
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "nope", []byte("Arg2"), []byte("Arg3"))
require.NotNil(t, err)
assert.Equal(t, tchannel.ErrCodeUnexpected, tchannel.GetSystemErrorCode(err), "err: %v", err)
calls := relaytest.NewMockStats()
calls.Add(ts.ServiceName(), ts.ServiceName(), "nope").Failed("unexpected-error").End()
ts.AssertRelayStats(calls)
})
}
type onErrorTestHandler struct {
*testHandler
onError func(ctx context.Context, err error)
}
func (h onErrorTestHandler) OnError(ctx context.Context, err error) {
h.onError(ctx, err)
}
func TestTimeout(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
// onError may be called when the block call tries to write the call response.
onError := func(ctx context.Context, err error) {
assert.Equal(t, tchannel.ErrTimeout, err, "onError err should be ErrTimeout")
assert.Equal(t, context.DeadlineExceeded, ctx.Err(), "Context should timeout")
}
testHandler := onErrorTestHandler{newTestHandler(t), onError}
ts.Register(raw.Wrap(testHandler), "block")
ctx, cancel := tchannel.NewContext(testutils.Timeout(15 * time.Millisecond))
defer cancel()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "block", []byte("Arg2"), []byte("Arg3"))
assert.Equal(t, tchannel.ErrTimeout, err)
// Verify the server-side receives an error from the context.
select {
case err := <-testHandler.blockErr:
assert.Equal(t, context.DeadlineExceeded, err, "Server should have received timeout")
case <-time.After(time.Second):
t.Errorf("Server did not receive call, may need higher timeout")
}
calls := relaytest.NewMockStats()
calls.Add(ts.ServiceName(), ts.ServiceName(), "block").Failed("timeout").End()
ts.AssertRelayStats(calls)
})
}
func TestLargeMethod(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
largeMethod := testutils.RandBytes(16*1024 + 1)
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), string(largeMethod), nil, nil)
assert.Equal(t, tchannel.ErrMethodTooLarge, err)
})
}
func TestLargeTimeout(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ts.Register(raw.Wrap(newTestHandler(t)), "echo")
ctx, cancel := tchannel.NewContext(1000 * time.Second)
defer cancel()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "echo", testArg2, testArg3)
assert.NoError(t, err, "Call failed")
calls := relaytest.NewMockStats()
calls.Add(ts.ServiceName(), ts.ServiceName(), "echo").Succeeded().End()
ts.AssertRelayStats(calls)
})
}
func TestFragmentation(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ts.Register(raw.Wrap(newTestHandler(t)), "echo")
arg2 := make([]byte, tchannel.MaxFramePayloadSize*2)
for i := 0; i < len(arg2); i++ {
arg2[i] = byte('a' + (i % 10))
}
arg3 := make([]byte, tchannel.MaxFramePayloadSize*3)
for i := 0; i < len(arg3); i++ {
arg3[i] = byte('A' + (i % 10))
}
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
respArg2, respArg3, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "echo", arg2, arg3)
require.NoError(t, err)
assert.Equal(t, arg2, respArg2)
assert.Equal(t, arg3, respArg3)
calls := relaytest.NewMockStats()
calls.Add(ts.ServiceName(), ts.ServiceName(), "echo").Succeeded().End()
ts.AssertRelayStats(calls)
})
}
func TestFragmentationSlowReader(t *testing.T) {
// Inbound forward will timeout and cause a warning log.
opts := testutils.NewOpts().
AddLogFilter("Unable to forward frame", 1).
AddLogFilter("Connection error", 1)
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
startReading, handlerComplete := make(chan struct{}), make(chan struct{})
handler := func(ctx context.Context, call *tchannel.InboundCall) {
<-startReading
<-ctx.Done()
_, err := raw.ReadArgs(call)
assert.Error(t, err, "ReadArgs should fail since frames will be dropped due to slow reading")
close(handlerComplete)
}
ts.Register(tchannel.HandlerFunc(handler), "echo")
arg2 := testutils.RandBytes(tchannel.MaxFramePayloadSize * tchannel.MexChannelBufferSize)
arg3 := testutils.RandBytes(tchannel.MaxFramePayloadSize * (tchannel.MexChannelBufferSize + 1))
ctx, cancel := tchannel.NewContext(testutils.Timeout(30 * time.Millisecond))
defer cancel()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "echo", arg2, arg3)
assert.Error(t, err, "Call should timeout due to slow reader")
close(startReading)
select {
case <-handlerComplete:
case <-time.After(testutils.Timeout(70 * time.Millisecond)):
t.Errorf("Handler not called, context timeout may be too low")
}
calls := relaytest.NewMockStats()
calls.Add(ts.ServiceName(), ts.ServiceName(), "echo").Failed("timeout").End()
ts.AssertRelayStats(calls)
})
}
func TestWriteArg3AfterTimeout(t *testing.T) {
// The channel reads and writes during timeouts, causing warning logs.
opts := testutils.NewOpts().DisableLogVerification()
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
timedOut := make(chan struct{})
handler := func(ctx context.Context, call *tchannel.InboundCall) {
_, err := raw.ReadArgs(call)
assert.NoError(t, err, "Read args failed")
response := call.Response()
assert.NoError(t, tchannel.NewArgWriter(response.Arg2Writer()).Write(nil), "Write Arg2 failed")
writer, err := response.Arg3Writer()
assert.NoError(t, err, "Arg3Writer failed")
for {
if _, err := writer.Write(testutils.RandBytes(4)); err != nil {
assert.Equal(t, err, tchannel.ErrTimeout, "Handler should timeout")
close(timedOut)
return
}
runtime.Gosched()
}
}
ts.Register(tchannel.HandlerFunc(handler), "call")
ctx, cancel := tchannel.NewContext(testutils.Timeout(100 * time.Millisecond))
defer cancel()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "call", nil, nil)
assert.Equal(t, err, tchannel.ErrTimeout, "Call should timeout")
// Wait for the write to complete, make sure there are no errors.
select {
case <-time.After(testutils.Timeout(60 * time.Millisecond)):
t.Errorf("Handler should have failed due to timeout")
case <-timedOut:
}
calls := relaytest.NewMockStats()
calls.Add(ts.ServiceName(), ts.ServiceName(), "call").Failed("timeout").Succeeded().End()
ts.AssertRelayStats(calls)
})
}
func TestLargeSendSystemError(t *testing.T) {
largeStr := strings.Repeat("0123456789", 10000)
tests := []struct {
msg string
err error
wantErr string
}{
{
msg: "error message too long",
err: errors.New(largeStr),
wantErr: "too long",
},
{
msg: "max allowed error message",
err: errors.New(largeStr[:math.MaxUint16-1]),
wantErr: typed.ErrBufferFull.Error(), // error message is within length, but it overflows the frame.
},
}
for _, tt := range tests {
t.Run(tt.msg, func(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
opts := testutils.NewOpts().AddLogFilter("Couldn't create outbound frame.", 1)
client := ts.NewClient(opts)
conn, err := client.Connect(ctx, ts.HostPort())
require.NoError(t, err, "Connect failed")
err = conn.SendSystemError(1, tchannel.Span{}, tt.err)
require.Error(t, err, "Expect err")
assert.Contains(t, err.Error(), tt.wantErr, "unexpected error")
})
})
}
}
func TestWriteErrorAfterTimeout(t *testing.T) {
// TODO: Make this test block at different points (e.g. before, during read/write).
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
timedOut := make(chan struct{})
done := make(chan struct{})
handler := func(ctx context.Context, call *tchannel.InboundCall) {
<-ctx.Done()
<-timedOut
_, err := raw.ReadArgs(call)
assert.Equal(t, tchannel.ErrTimeout, err, "Read args should fail with timeout")
response := call.Response()
assert.Equal(t, tchannel.ErrTimeout, response.SendSystemError(tchannel.ErrServerBusy), "SendSystemError should fail")
close(done)
}
ts.Register(tchannel.HandlerFunc(handler), "call")
ctx, cancel := tchannel.NewContext(testutils.Timeout(30 * time.Millisecond))
defer cancel()
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "call", nil, testutils.RandBytes(100000))
assert.Equal(t, err, tchannel.ErrTimeout, "Call should timeout")
close(timedOut)
select {
case <-done:
case <-time.After(time.Second):
t.Errorf("Handler not called, timeout may be too low")
}
calls := relaytest.NewMockStats()
calls.Add(ts.ServiceName(), ts.ServiceName(), "call").Failed("timeout").End()
ts.AssertRelayStats(calls)
})
}
func TestWriteAfterConnectionError(t *testing.T) {
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
// Closing network connections can lead to warnings in many places.
// TODO: Relay is disabled due to https://github.com/uber/tchannel-go/issues/390
// Enabling relay causes the test to be flaky.
opts := testutils.NewOpts().DisableLogVerification().NoRelay()
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
testutils.RegisterEcho(ts.Server(), nil)
server := ts.Server()
call, err := server.BeginCall(ctx, ts.HostPort(), server.ServiceName(), "echo", nil)
require.NoError(t, err, "Call failed")
w, err := call.Arg2Writer()
require.NoError(t, err, "Arg2Writer failed")
require.NoError(t, writeFlushStr(w, "initial"), "write initial failed")
// Now close the underlying network connection, writes should fail.
_, conn := tchannel.OutboundConnection(call)
conn.Close()
// Writes should start failing pretty soon.
var writeErr error
for i := 0; i < 100; i++ {
if writeErr = writeFlushStr(w, "f"); writeErr != nil {
break
}
time.Sleep(time.Millisecond)
}
if assert.Error(t, writeErr, "Writes should fail after a connection is closed") {
assert.Equal(t, tchannel.ErrCodeNetwork, tchannel.GetSystemErrorCode(writeErr), "write should fail due to network error")
}
})
}
func TestReadTimeout(t *testing.T) {
// The error frame may fail to send since the connection closes before the handler sends it
// or the handler connection may be closed as it sends when the other side closes the conn.
opts := testutils.NewOpts().
AddLogFilter("Couldn't send outbound error frame", 1).
AddLogFilter("Connection error", 1, "site", "read frames").
AddLogFilter("Connection error", 1, "site", "write frames").
AddLogFilter("simpleHandler OnError", 1,
"error", "failed to send error frame, connection state connectionClosed")
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
sn := ts.ServiceName()
calls := relaytest.NewMockStats()
for i := 0; i < 10; i++ {
ctx, cancel := tchannel.NewContext(time.Second)
handler := func(ctx context.Context, args *raw.Args) (*raw.Res, error) {
defer cancel()
return nil, tchannel.ErrRequestCancelled
}
ts.RegisterFunc("call", handler)
_, _, _, err := raw.Call(ctx, ts.Server(), ts.HostPort(), ts.ServiceName(), "call", nil, nil)
assert.Equal(t, err, tchannel.ErrRequestCancelled, "Call should fail due to cancel")
calls.Add(sn, sn, "call").Failed("cancelled").End()
}
ts.AssertRelayStats(calls)
})
}
func TestWriteTimeout(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ch := ts.Server()
ctx, cancel := tchannel.NewContext(testutils.Timeout(15 * time.Millisecond))
defer cancel()
call, err := ch.BeginCall(ctx, ts.HostPort(), ch.ServiceName(), "call", nil)
require.NoError(t, err, "Call failed")
writer, err := call.Arg2Writer()
require.NoError(t, err, "Arg2Writer failed")
_, err = writer.Write([]byte{1})
require.NoError(t, err, "Write initial bytes failed")
<-ctx.Done()
_, err = io.Copy(writer, testreader.Looper([]byte{1}))
assert.Equal(t, tchannel.ErrTimeout, err, "Write should fail with timeout")
ts.AssertRelayStats(relaytest.NewMockStats())
})
}
func TestGracefulClose(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
ch2 := ts.NewServer(nil)
hp2 := ch2.PeerInfo().HostPort
defer ch2.Close()
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
assert.NoError(t, ts.Server().Ping(ctx, hp2), "Ping from ch1 -> ch2 failed")
assert.NoError(t, ch2.Ping(ctx, ts.HostPort()), "Ping from ch2 -> ch1 failed")
// No stats for pings.
ts.AssertRelayStats(relaytest.NewMockStats())
})
}
func TestNetDialTimeout(t *testing.T) {
// timeoutHostPort uses a blackholed address (RFC 6890) with a port
// reserved for documentation. This address should always cause a timeout.
const timeoutHostPort = "192.18.0.254:44444"
timeoutPeriod := testutils.Timeout(50 * time.Millisecond)
client := testutils.NewClient(t, nil)
defer client.Close()
started := time.Now()
ctx, cancel := tchannel.NewContext(timeoutPeriod)
defer cancel()
err := client.Ping(ctx, timeoutHostPort)
if !assert.Error(t, err, "Ping to blackhole address should fail") {
return
}
if strings.Contains(err.Error(), "network is unreachable") {
t.Skipf("Skipping test, as network interface may not be available")
}
d := time.Since(started)
assert.Equal(t, tchannel.ErrTimeout, err, "Ping expected to fail with timeout")
assert.True(t, d >= timeoutPeriod, "Timeout should take more than %v, took %v", timeoutPeriod, d)
}
func TestConnectTimeout(t *testing.T) {
opts := testutils.NewOpts().DisableLogVerification()
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
// Set up a relay that will delay the initial init req.
testComplete := make(chan struct{})
relayFunc := func(outgoing bool, f *tchannel.Frame) *tchannel.Frame {
select {
case <-time.After(testutils.Timeout(200 * time.Millisecond)):
return f
case <-testComplete:
// TODO: We should be able to forward the frame and have this test not fail.
// Currently, it fails since the sequence of events is:
// Server receives a TCP connection
// Channel.Close() is called on the server
// Server's TCP connection receives an init req
// Since we don't currently track pending connections, the open TCP connection is not closed, and
// we process the init req. This leaves an open connection at the end of the test.
return nil
}
}
relay, shutdown := testutils.FrameRelay(t, ts.HostPort(), relayFunc)
defer shutdown()
// Make a call with a long timeout, but short connect timeout.
// We expect the call to fall almost immediately with ErrTimeout.
ctx, cancel := tchannel.NewContextBuilder(2 * time.Second).
SetConnectTimeout(testutils.Timeout(100 * time.Millisecond)).
Build()
defer cancel()
client := ts.NewClient(opts)
err := client.Ping(ctx, relay)
assert.Equal(t, tchannel.ErrTimeout, err, "Ping should timeout due to timeout relay")
// Note: we do not defer this, as we need to close(testComplete) before
// we call shutdown since shutdown waits for the relay to close, which
// is stuck waiting inside of our custom relay function.
close(testComplete)
})
}
func TestParallelConnectionAccepts(t *testing.T) {
opts := testutils.NewOpts().AddLogFilter("Failed during connection handshake", 1)
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
testutils.RegisterEcho(ts.Server(), nil)
// Start a connection attempt that should timeout.
conn, err := net.Dial("tcp", ts.HostPort())
defer conn.Close()
require.NoError(t, err, "Dial failed")
// When we try to make a call using a new client, it will require a
// new connection, and this verifies that the previous connection attempt
// and handshake do not impact the call.
client := ts.NewClient(nil)
testutils.AssertEcho(t, client, ts.HostPort(), ts.ServiceName())
})
}
func TestConnectionIDs(t *testing.T) {
testutils.WithTestServer(t, nil, func(t testing.TB, ts *testutils.TestServer) {
var inbound, outbound []uint32
relayFunc := func(outgoing bool, f *tchannel.Frame) *tchannel.Frame {
if outgoing {
outbound = append(outbound, f.Header.ID)
} else {
inbound = append(inbound, f.Header.ID)
}
return f
}
relay, shutdown := testutils.FrameRelay(t, ts.HostPort(), relayFunc)
defer shutdown()
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
s2 := ts.NewServer(nil)
require.NoError(t, s2.Ping(ctx, relay), "Ping failed")
assert.Equal(t, []uint32{1, 2}, outbound, "Unexpected outbound IDs")
assert.Equal(t, []uint32{1, 2}, inbound, "Unexpected outbound IDs")
// We want to reuse the same connection for the rest of the test which
// only makes sense when the relay is not used.
if ts.HasRelay() {
return
}
inbound = nil
outbound = nil
// We will reuse the inbound connection, but since the inbound connection
// hasn't originated any outbound requests, we'll use id 1.
require.NoError(t, ts.Server().Ping(ctx, s2.PeerInfo().HostPort), "Ping failed")
assert.Equal(t, []uint32{1}, outbound, "Unexpected outbound IDs")
assert.Equal(t, []uint32{1}, inbound, "Unexpected outbound IDs")
})
}
func TestTosPriority(t *testing.T) {
ctx, cancel := tchannel.NewContext(time.Second)
defer cancel()
opts := testutils.NewOpts().SetServiceName("s1").SetTosPriority(tos.Lowdelay)
testutils.WithTestServer(t, opts, func(t testing.TB, ts *testutils.TestServer) {
ts.Register(raw.Wrap(newTestHandler(t)), "echo")
outbound, err := ts.Server().BeginCall(ctx, ts.HostPort(), "s1", "echo", nil)
require.NoError(t, err, "BeginCall failed")
_, outboundNetConn := tchannel.OutboundConnection(outbound)
connTosPriority, err := isTosPriority(outboundNetConn, tos.Lowdelay)
require.NoError(t, err, "Checking TOS priority failed")
assert.Equal(t, connTosPriority, true)
_, _, _, err = raw.WriteArgs(outbound, []byte("arg2"), []byte("arg3"))
require.NoError(t, err, "Failed to write to outbound conn")
})
}
func TestPeerStatusChangeClientReduction(t *testing.T) {
sopts := testutils.NewOpts().NoRelay()
testutils.WithTestServer(t, sopts, func(t testing.TB, ts *testutils.TestServer) {
server := ts.Server()
testutils.RegisterEcho(server, nil)
changes := make(chan int, 2)
copts := testutils.NewOpts().SetOnPeerStatusChanged(func(p *tchannel.Peer) {
i, o := p.NumConnections()
assert.Equal(t, 0, i, "no inbound connections to client")
changes <- o
})
// Induce the creation of a connection from client to server.
client := ts.NewClient(copts)
require.NoError(t, testutils.CallEcho(client, ts.HostPort(), ts.ServiceName(), nil))
assert.Equal(t, 1, <-changes, "event for first connection")
// Re-use
testutils.AssertEcho(t, client, ts.HostPort(), ts.ServiceName())
// Induce the destruction of a connection from the server to the client.
server.Close()
assert.Equal(t, 0, <-changes, "event for second disconnection")
client.Close()
assert.Len(t, changes, 0, "unexpected peer status changes")
})
}
func TestPeerStatusChangeClient(t *testing.T) {
sopts := testutils.NewOpts().NoRelay()
testutils.WithTestServer(t, sopts, func(t testing.TB, ts *testutils.TestServer) {
server := ts.Server()
testutils.RegisterEcho(server, nil)
changes := make(chan int, 2)
copts := testutils.NewOpts().SetOnPeerStatusChanged(func(p *tchannel.Peer) {
i, o := p.NumConnections()
assert.Equal(t, 0, i, "no inbound connections to client")
changes <- o
})
// Induce the creation of a connection from client to server.