Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnvBase is exported but shouldn't be #1173

Open
leighmcculloch opened this issue Nov 21, 2023 · 0 comments
Open

EnvBase is exported but shouldn't be #1173

leighmcculloch opened this issue Nov 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@leighmcculloch
Copy link
Member

Follow on from:

At the moment generated code is directly using the EnvBase and Guest fns, when it should be using SDK functionality. Generated code should make sense to developers and be handle writable. The optimizations that EnvBase offers should also be usable in the SDK.

Today what we have is optimizations used in the generated code that aren't usable outside of it with SDK types.

This issue should involve adding functions to SDK type to surface the EnvBase functionality. Then generated code can be updated to use those SDK functions.
@leighmcculloch leighmcculloch added the bug Something isn't working label Nov 21, 2023
@leighmcculloch leighmcculloch changed the title EnvBase is exported EnvBase is exported but shouldn't be Nov 21, 2023
This was referenced Nov 21, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leighmcculloch and others