Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently return None from setter methods #1392

Open
gadomski opened this issue Aug 21, 2024 · 0 comments
Open

Consistently return None from setter methods #1392

gadomski opened this issue Aug 21, 2024 · 0 comments
Labels
breaking Represents a potentially breaking change that may warrant a major version release enhancement
Milestone

Comments

@gadomski
Copy link
Member

Throughout pystac, "setter" methods usually return None, e.g.:

However, there are two instances (that I can find) where setters return something:

I think we should change those two methods to return None to make things consistent across the library. This can be part of a v2.0 since it is a breaking change.

@gadomski gadomski added the breaking Represents a potentially breaking change that may warrant a major version release label Aug 21, 2024
@gadomski gadomski added this to the v2.0 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Represents a potentially breaking change that may warrant a major version release enhancement
Projects
None yet
Development

No branches or pull requests

1 participant