Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphiQL not working in RDS implementation #256

Open
sid88in opened this issue Jan 8, 2018 · 3 comments
Open

GraphiQL not working in RDS implementation #256

sid88in opened this issue Jan 8, 2018 · 3 comments
Labels

Comments

@sid88in
Copy link
Collaborator

sid88in commented Jan 8, 2018

GraphQL endpoint works but graphiQL and playground doesn't work

@sid88in sid88in added the bug label Jan 8, 2018
@Ponjimon
Copy link
Contributor

Ponjimon commented Feb 9, 2018

Yes, I noticed this too.

It's the same for the playground.

They need to be changed to this:

exports.playgroundHandler = (event, context, callback) => {
    context.callbackWaitsForEmptyEventLoop = false;
    return lambdaPlayground({
        endpoint: getGraphQLEndpoint(),
    })(event, context, callback);
};

exports.graphiqlHandler = (event, context, callback) => {
    context.callbackWaitsForEmptyEventLoop = false;
    return graphiqlLambda({
        endpointURL: getGraphQLEndpoint(),
    })(event, context, callback);
};

Obviously swap the getGraphQLEndpoint() method

@sid88in
Copy link
Collaborator Author

sid88in commented Feb 9, 2018

@lookapanda does it work with these changes? can you please test it and create a PR :) 🎉 🎉

cc @pradel

@sid88in
Copy link
Collaborator Author

sid88in commented Feb 12, 2018

@lookapanda just tested graphiql doesn't work with these changes. will be great if you can test it once something next week to see if I am missing anything.

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants