Add explanation to Part 1 introduction #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@laney0808 This should be in the PR description (not a separate comment), and should be |
gongg21
reviewed
Sep 28, 2024
| @@ -15,6 +15,13 @@ Imagine yourself as a director of a play. First you provision the props that you | |||
|
|
|||
| A JavaFX application is like a play you are directing. Instead of creating props, you create `Node`s (`Node`s are the fundamental building blocks of a JavaFX application), and place them onto a `Scene` (a scene is a graph of `Node`s). Then, you set your `Scene` on a `Stage` provided by JavaFX. When you call `Stage#show()` method, JavaFX renders a window with your `Stage` on it. | |||
|
|
|||
| <box type="tip" seamless> | |||
| The `Stage` is like a window in a desktop application. It is the top-level container for a JavaFX application. | |||
There was a problem hiding this comment.
Maybe we could add, for greater clarity, that the Stage consists of different scenes at different times, i.e. depending on the current action/state, the Scene on the Stage is different?
There was a problem hiding this comment.
Great point! Will add in the next commit. Thank you!
damithc
pushed a commit
that referenced
this pull request
Sep 29, 2024
Adapated from #89 by @laney0808
|
Thanks for this PR @laney0808 In future, remember to preview the changes locally first. The code in this PR doesn't render as intended because it doesn't have a blank line below the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the meaning of Stage, Scene, Root node and Node in Part 1 introduction for clarity.
Fixes #90